From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEECEC433DB for ; Fri, 12 Mar 2021 02:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E6C064F70 for ; Fri, 12 Mar 2021 02:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231473AbhCLCWp (ORCPT ); Thu, 11 Mar 2021 21:22:45 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:60487 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230494AbhCLCW1 (ORCPT ); Thu, 11 Mar 2021 21:22:27 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1615515747; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=dabB/BnEgbYh3GceoupDKzko3mWSJ2hXdoZRvEow4+g=; b=t340J3aAIEkz40J8y+3pbvOvRaY7kVf6xlciVzGJ3PtrW7u/amwZZl1jh3bFuLmnAi7ZaGP5 9uI/Guli/OrfI/jgPMoD5TZhRgJdpTERnfm08JnGO1PcFqI0hZlpn03QlgVnHmeLNAKpqCa1 Mel1ds6Jod0OcTpF5xrprYZZTqE= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 604ad05ae2200c0a0d757e50 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 12 Mar 2021 02:22:18 GMT Sender: subashab=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 16F24C433CA; Fri, 12 Mar 2021 02:22:18 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: subashab) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5A9C9C433CA; Fri, 12 Mar 2021 02:22:17 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 11 Mar 2021 19:22:17 -0700 From: subashab@codeaurora.org To: David Ahern Cc: davem@davemloft.net, kuba@kernel.org, yoshfuji@linux-ipv6.org, dsahern@kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next] net: ipv6: addrconf: Add accept_ra_prefix_route. In-Reply-To: References: <1615402193-12122-1-git-send-email-subashab@codeaurora.org> Message-ID: X-Sender: subashab@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2021-03-10 14:33, subashab@codeaurora.org wrote: > On 2021-03-10 12:28, David Ahern wrote: >> On 3/10/21 11:49 AM, Subash Abhinov Kasiviswanathan wrote: >>> Added new procfs flag to toggle the automatic addition of prefix >>> routes on a per device basis. The new flag is accept_ra_prefix_route. >>> >>> A value of 0 for the flag maybe used in some forwarding scenarios >>> when a userspace daemon is managing the routing. >>> Manual deletion of the kernel installed route was not sufficient as >>> kernel was adding back the route. >>> >>> Defaults to 1 as to not break existing behavior. >>> >>> Signed-off-by: Subash Abhinov Kasiviswanathan >>> >>> --- >>> Documentation/networking/ip-sysctl.rst | 10 ++++++++++ >>> include/linux/ipv6.h | 1 + >>> include/uapi/linux/ipv6.h | 1 + >>> net/ipv6/addrconf.c | 16 +++++++++++++--- >>> 4 files changed, 25 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/networking/ip-sysctl.rst >>> b/Documentation/networking/ip-sysctl.rst >>> index c7952ac..9f0d92d 100644 >>> --- a/Documentation/networking/ip-sysctl.rst >>> +++ b/Documentation/networking/ip-sysctl.rst >>> @@ -2022,6 +2022,16 @@ accept_ra_mtu - BOOLEAN >>> - enabled if accept_ra is enabled. >>> - disabled if accept_ra is disabled. >>> >>> +accept_ra_prefix_route - BOOLEAN >>> + Apply the prefix route based on the RA. If disabled, kernel >>> + does not install the route. This can be used if a userspace >>> + daemon is managing the routing. >>> + >>> + Functional default: >>> + >>> + - enabled if accept_ra_prefix_route is enabled >>> + - disabled if accept_ra_prefix_route is disabled >>> + >>> accept_redirects - BOOLEAN >>> Accept Redirects. >>> >> >> this seems to duplicate accept_ra_pinfo > > Thanks David. We will try out that entry instead and check. We are seeing that the interface itself doesn't get the address assigned via RA when setting accept_ra_pinfo = 0. We would like to have the interface address assigned via SLAAC here while the route management would be handled via the userspace daemon. In that case, we do not want the kernel installed route to be present (behavior controlled via this proc entry).