* [PATCH] [v2] plfxlc: fix le16_to_cpu warning for beacon_interval
@ 2022-04-29 10:44 Srinivasan Raju
2022-04-29 10:59 ` Johannes Berg
0 siblings, 1 reply; 2+ messages in thread
From: Srinivasan Raju @ 2022-04-29 10:44 UTC (permalink / raw)
Cc: Kalle Valo, David S. Miller, edumazet@google.com, Jakub Kicinski,
pabeni@redhat.com, open list:NETWORKING DRIVERS (WIRELESS),
open list:NETWORKING DRIVERS, open list
Fix the following sparse warnings:
drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Srinivasan Raju <srini.raju@purelifi.com>
---
drivers/net/wireless/purelifi/plfxlc/chip.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c
index a5ec10b66ed5..79d187cf3715 100644
--- a/drivers/net/wireless/purelifi/plfxlc/chip.c
+++ b/drivers/net/wireless/purelifi/plfxlc/chip.c
@@ -29,11 +29,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval,
u8 dtim_period, int type)
{
if (!interval ||
- (chip->beacon_set &&
- le16_to_cpu(chip->beacon_interval) == interval))
+ (chip->beacon_set && chip->beacon_interval) == interval)
return 0;
- chip->beacon_interval = cpu_to_le16(interval);
+ chip->beacon_interval = interval;
chip->beacon_set = true;
return plfxlc_usb_wreq(chip->usb.ez_usb,
&chip->beacon_interval,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [v2] plfxlc: fix le16_to_cpu warning for beacon_interval
2022-04-29 10:44 [PATCH] [v2] plfxlc: fix le16_to_cpu warning for beacon_interval Srinivasan Raju
@ 2022-04-29 10:59 ` Johannes Berg
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Berg @ 2022-04-29 10:59 UTC (permalink / raw)
To: Srinivasan Raju
Cc: Kalle Valo, David S. Miller, edumazet@google.com, Jakub Kicinski,
pabeni@redhat.com, open list:NETWORKING DRIVERS (WIRELESS),
open list:NETWORKING DRIVERS, open list
On Fri, 2022-04-29 at 10:44 +0000, Srinivasan Raju wrote:
> Fix the following sparse warnings:
>
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: expected unsigned short [usertype] beacon_interval
> drivers/net/wireless/purelifi/plfxlc/chip.c:36:31: sparse: got restricted __le16 [usertype]
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Srinivasan Raju <srini.raju@purelifi.com>
> ---
> drivers/net/wireless/purelifi/plfxlc/chip.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/purelifi/plfxlc/chip.c b/drivers/net/wireless/purelifi/plfxlc/chip.c
> index a5ec10b66ed5..79d187cf3715 100644
> --- a/drivers/net/wireless/purelifi/plfxlc/chip.c
> +++ b/drivers/net/wireless/purelifi/plfxlc/chip.c
> @@ -29,11 +29,10 @@ int plfxlc_set_beacon_interval(struct plfxlc_chip *chip, u16 interval,
> u8 dtim_period, int type)
> {
> if (!interval ||
> - (chip->beacon_set &&
> - le16_to_cpu(chip->beacon_interval) == interval))
> + (chip->beacon_set && chip->beacon_interval) == interval)
>
I think you got the parentheses wrong.
johannes
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-29 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-29 10:44 [PATCH] [v2] plfxlc: fix le16_to_cpu warning for beacon_interval Srinivasan Raju
2022-04-29 10:59 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).