From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next] net: core: change bool members of struct
 net_device to bitfield members
Date: Mon, 8 Oct 2018 23:21:27 +0200
Message-ID: <b172bfa0-d3bf-94b8-bb5f-0bd849e753b7@gmail.com>
References: <c1d1e04d-693a-b81e-323a-d04b1dcd6544@gmail.com>
 <20181008142009.7b32df14@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm1-f67.google.com ([209.85.128.67]:55103 "EHLO
        mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725828AbeJIEfR (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 9 Oct 2018 00:35:17 -0400
Received: by mail-wm1-f67.google.com with SMTP id r63-v6so9431639wma.4
        for <netdev@vger.kernel.org>; Mon, 08 Oct 2018 14:21:33 -0700 (PDT)
In-Reply-To: <20181008142009.7b32df14@xeon-e3>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 08.10.2018 23:20, Stephen Hemminger wrote:
> On Mon, 8 Oct 2018 22:00:51 +0200
> Heiner Kallweit <hkallweit1@gmail.com> wrote:
> 
>>   *
>> + *	@uc_promisc:	Counter that indicates promiscuous mode
>> + *			has been enabled due to the need to listen to
>> + *			additional unicast addresses in a device that
>> + *			does not implement ndo_set_rx_mode()
>> + *
> 
> I see you just moved the pre-existing comment, but it the comment
> looks incorrect. uc_promisc is not a counter but a flag. A counter would
> have more than two states normally.
> 
Right. A v2 fixing the comment has been submitted already.