From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BED1FC388F7 for ; Thu, 29 Oct 2020 02:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66F1220757 for ; Thu, 29 Oct 2020 02:34:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tOTX7t2O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391333AbgJ2CeN (ORCPT ); Wed, 28 Oct 2020 22:34:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729940AbgJ2Cdp (ORCPT ); Wed, 28 Oct 2020 22:33:45 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21467C0613CF; Wed, 28 Oct 2020 19:33:45 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id z5so1831414iob.1; Wed, 28 Oct 2020 19:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6GytV/YfZqiq2s9nqgfVb891weslak10f/ixf3YW0ZE=; b=tOTX7t2OIuZH3UnQFep/TOZBB00cBS/IWDotGJGlh0t/UEMZfTdbfHV1569JAZg06I R88JxH9OWlL0jGvRZqxUBONLlRyDJjg7ZR71RfK0Bw7bggQhbubKBt45WvFQ6IsnFaI5 p8OBvxk9k7ao+werHg67+vw9y/AbBW6hNN6zT4fjgqNMdQdgqa9XRpxqbRjPtydqgmK0 5d9iAHTNGYtNi79KGkv6CPhuYkHw1l0fqeRSMp12oFkxLKZM+wz7qbbmIFLVdXz123Xm CrH8OfmehgUtsvjlpvFtSo88ZJCw6l2yK5an0ANhSRvb3ZwJdL1j4uVRYcU3YcsrO4SQ yaYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6GytV/YfZqiq2s9nqgfVb891weslak10f/ixf3YW0ZE=; b=rcJr0YkL4THhZPYlQvqBfXZaZZ3Krx9Gq3oFLZxK/LW1qeaAvnftyQmjH/g6U+i/gH VMOR6/UtG0wjfX0tH1BHABlHBcHqWk2Y8oCH5pVWi26Rp+wv+gUcWqcia70FvpMxW/VB COvq+ccL7SKI6kxh9zSxtBIkPUYOrnCLu8PusWQqNObkZivE3lhcYhqHiEGvMXERYHiA zRgyyuEuHJXI+Nq+4TXvah546K47M860IrW5cGuG2EGy3DZVdWv71Ha7DV1bEt7OanUH RWwNiVir9BL4QX05FTgx/Y8exQ4nWVbNQmcZVRMybMXWSqv93MHXjf/Xu3wqnie82C9C ojrg== X-Gm-Message-State: AOAM533JEhj4drukd5249hOGLZUI1FaLJwOesmx0/KuJcCflJNQwG829 X318I8ZbXE47lUFnqmZe3sA= X-Google-Smtp-Source: ABdhPJx6pHJr5RkSB7hHl65PFO3eVLmalsEfN019T1FytM0+LEJaP74JtpGFu6rRHe+Os3eR4dc7tg== X-Received: by 2002:a05:6638:10ea:: with SMTP id g10mr1885135jae.9.1603938824510; Wed, 28 Oct 2020 19:33:44 -0700 (PDT) Received: from Davids-MacBook-Pro.local ([2601:282:803:7700:e1b0:db06:9a2d:91c5]) by smtp.googlemail.com with ESMTPSA id v85sm1365404ilk.50.2020.10.28.19.33.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2020 19:33:44 -0700 (PDT) Subject: Re: [PATCHv2 iproute2-next 0/5] iproute2: add libbpf support To: Andrii Nakryiko , Hangbin Liu Cc: Stephen Hemminger , Daniel Borkmann , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , David Miller , Jesper Dangaard Brouer , Networking , bpf , Jiri Benc , Andrii Nakryiko , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= References: <20201023033855.3894509-1-haliu@redhat.com> <20201028132529.3763875-1-haliu@redhat.com> <7babcccb-2b31-f9bf-16ea-6312e449b928@gmail.com> <20201029020637.GM2408@dhcp-12-153.nay.redhat.com> From: David Ahern Message-ID: Date: Wed, 28 Oct 2020 20:33:43 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 10/28/20 8:27 PM, Andrii Nakryiko wrote: > On Wed, Oct 28, 2020 at 7:06 PM Hangbin Liu wrote: >> >> On Wed, Oct 28, 2020 at 05:02:34PM -0600, David Ahern wrote: >>> fails to compile on Ubuntu 20.10: >>> >>> root@u2010-sfo3:~/iproute2.git# ./configure >>> TC schedulers >>> ATM yes >>> IPT using xtables >>> IPSET yes >>> >>> iptables modules directory: /usr/lib/x86_64-linux-gnu/xtables >>> libc has setns: yes >>> SELinux support: yes >>> libbpf support: yes >>> ELF support: yes >>> libmnl support: yes >>> Berkeley DB: no >>> need for strlcpy: yes >>> libcap support: yes >>> >>> root@u2010-sfo3:~/iproute2.git# make clean >>> >>> root@u2010-sfo3:~/iproute2.git# make -j 4 >>> ... >>> /usr/bin/ld: ../lib/libutil.a(bpf_libbpf.o): in function `load_bpf_object': >>> bpf_libbpf.c:(.text+0x3cb): undefined reference to >>> `bpf_program__section_name' >>> /usr/bin/ld: bpf_libbpf.c:(.text+0x438): undefined reference to >>> `bpf_program__section_name' >>> /usr/bin/ld: bpf_libbpf.c:(.text+0x716): undefined reference to >>> `bpf_program__section_name' >>> collect2: error: ld returned 1 exit status >>> make[1]: *** [Makefile:27: ip] Error 1 >>> make[1]: *** Waiting for unfinished jobs.... >>> make: *** [Makefile:64: all] Error 2 >> >> You need to update libbpf to latest version. > > Why not using libbpf from submodule? > no. iproute2 does not bring in libmnl, libc, ... a submodules. libbpf is not special. OS versions provide it and it needs to co-exist with packages.