From: Krzysztof Kozlowski <krzk@kernel.org>
To: "irving.ch.lin" <irving-ch.lin@mediatek.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Richard Cochran <richardcochran@gmail.com>
Cc: Qiqi Wang <qiqi.wang@mediatek.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-pm@vger.kernel.org,
netdev@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
sirius.wang@mediatek.com, vince-wl.liu@mediatek.com,
jh.hsu@mediatek.com
Subject: Re: [PATCH 1/6] dt-bindings: clock: mediatek: Add new MT8189 clock
Date: Mon, 18 Aug 2025 16:42:21 +0200 [thread overview]
Message-ID: <b1807a5a-9507-49e2-9a4b-5101078c7a90@kernel.org> (raw)
In-Reply-To: <20250818115754.1067154-2-irving-ch.lin@mediatek.com>
On 18/08/2025 13:57, irving.ch.lin wrote:
> From: Irving-ch Lin <irving-ch.lin@mediatek.com>
>
> Add the new binding documentation for system clock
> and functional clock on MediaTek MT8189.
>
> Signed-off-by: Irving-ch Lin <irving-ch.lin@mediatek.com>
Never tested so just quick review to for obvious issues. I won't bother
with full review :(
> +
> +examples:
> + - |
> + imp_iic_wrap_ws_clk@11b21000 {
1. Follow closely DTS coding style.
2. Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-18 14:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 11:57 [PATCH 0/6] Add support for MT8189 clock/power controller irving.ch.lin
2025-08-18 11:57 ` [PATCH 1/6] dt-bindings: clock: mediatek: Add new MT8189 clock irving.ch.lin
2025-08-18 14:36 ` Rob Herring (Arm)
2025-08-18 14:42 ` Krzysztof Kozlowski [this message]
2025-08-18 11:57 ` [PATCH 2/6] dt-bindings: power: mediatek: Add new MT8189 power irving.ch.lin
2025-08-18 14:37 ` Rob Herring (Arm)
2025-08-18 14:45 ` Krzysztof Kozlowski
2025-08-18 11:57 ` [PATCH 3/6] dt-bindings: clock: mediatek: Add MT8189 clock definitions irving.ch.lin
2025-08-18 14:46 ` Krzysztof Kozlowski
2025-08-18 14:47 ` Krzysztof Kozlowski
2025-08-18 11:57 ` [PATCH 4/6] dt-bindings: power: mediatek: Add MT8189 power domain definitions irving.ch.lin
2025-08-18 14:46 ` Krzysztof Kozlowski
2025-08-18 11:57 ` [PATCH 5/6] clk: mediatek: Add clock drivers for MT8189 SoC irving.ch.lin
2025-08-18 11:57 ` [PATCH 6/6] pmdomain: mediatek: Add power domain driver " irving.ch.lin
2025-08-18 23:57 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1807a5a-9507-49e2-9a4b-5101078c7a90@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=irving-ch.lin@mediatek.com \
--cc=jh.hsu@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=qiqi.wang@mediatek.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sirius.wang@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=vince-wl.liu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).