From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D0DC282C8 for ; Mon, 28 Jan 2019 20:28:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE3C620989 for ; Mon, 28 Jan 2019 20:28:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I7yYAqxY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727750AbfA1U2Y (ORCPT ); Mon, 28 Jan 2019 15:28:24 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44330 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbfA1U2Y (ORCPT ); Mon, 28 Jan 2019 15:28:24 -0500 Received: by mail-wr1-f68.google.com with SMTP id z5so19552701wrt.11 for ; Mon, 28 Jan 2019 12:28:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BrQV4CqDnOmsPcVCDqsFhkEvXs6yEl93kKG5hhRF1Cw=; b=I7yYAqxY8ekM8nez1ZpiiKqJYvsw0Z8B6G2gQxkwWzN0V3b3ZZzFv4yPLgdX8QiqUs 1+JaGzeSMs226rty+2CbafStkMvIEyVgjVbKLXdwO+rarbmIZzbCFrQE2r6wHyuE18vx lrkZ377IpEI+2qGVq7uJDqRI2LYV3YgDj0dZ07Ea7ljnHU/DHvNsAF3Lt7oGJmx3Anu4 aTLA/lnWxapkvIl9IJ4xJHfa7aWhQH8SAhDNnT49DlYqU5sXCotpDLxSkStcfENb5SO8 S1uNTdAPhIf3HwqSHTh6TLMxjzzqBNPbczG/k7Bf6tPTOdnPxHbxnjl6JUwtpqRhhz1v GPUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BrQV4CqDnOmsPcVCDqsFhkEvXs6yEl93kKG5hhRF1Cw=; b=sjL1BY6ViYxomUHhMwaPSqQuVI2ckTWE58SUJdKM12x1LXoxXkRBLbV6UCR5GyB8ok mSbCEZExS+SRptWoCRihfGukg7BZiku3bdx5I/BVQBhVVJMydQNoRIpIWphQnIcmM3Sk sxI8ieCZ2kwNYi8gqJfV+Dzth2l51JwfvYpwY5Ep/mqbvIDRavLYX+XVeRYcmNTXxdHK 2isEVEqx6j4aFWcuE2odXwQacstVIbGa6Zj238nSRSRhnd4nDfIFCjhVJSKa/czn433N yCKd2BvGRTdgbGFdM0QDJNVzGkx7+V3VhPmg1Nq6lFkaU6KLZCZwvR3KqDYHFJadiZz2 2rLw== X-Gm-Message-State: AJcUukdb5H41ypfFSme/SxSsqjXjccQ0gw9r1n1Ihp6Dz/+p0SPLROWs K2N0Gy5gDFSSRR5xmsMuvdDziAEt X-Google-Smtp-Source: ALg8bN6FcNxVwHgVhfjMR+cIdGYQyofhM59EX4EWeY4yeFboTS+2JxnUzHUXYouJwjbblzGYgks9Xw== X-Received: by 2002:adf:ecc8:: with SMTP id s8mr22497350wro.208.1548707302338; Mon, 28 Jan 2019 12:28:22 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:2c9c:e1a3:b321:9449? (p200300EA8BF1E2002C9CE1A3B3219449.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:2c9c:e1a3:b321:9449]) by smtp.googlemail.com with ESMTPSA id h13sm98328050wrp.61.2019.01.28.12.28.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 12:28:21 -0800 (PST) Subject: Re: WoL broken in r8169.c since kernel 4.19 To: Marc Haber Cc: "netdev@vger.kernel.org" References: <6ae02156-8903-70fd-675f-a5aee9c452b4@gmail.com> <20190125120210.GC27062@torres.zugschlus.de> <548c1682-ad7c-3a0a-b2ea-2207f328b070@gmail.com> <20190126135640.GD27062@torres.zugschlus.de> <1a17454a-3017-7283-89d6-206681ca4c47@gmail.com> <20190126170752.GE27062@torres.zugschlus.de> <6ecafe07-3278-a9c4-d76d-971c0df26ce8@gmail.com> <20190127205555.GF27062@torres.zugschlus.de> <64b22f62-ca8a-caee-5a39-f06ffe6598d1@gmail.com> <20190128073010.GG27062@torres.zugschlus.de> <20190128202235.GH27062@torres.zugschlus.de> From: Heiner Kallweit Message-ID: Date: Mon, 28 Jan 2019 21:28:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190128202235.GH27062@torres.zugschlus.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 28.01.2019 21:22, Marc Haber wrote: > On Mon, Jan 28, 2019 at 08:30:10AM +0100, Marc Haber wrote: >> On Sun, Jan 27, 2019 at 10:09:51PM +0100, Heiner Kallweit wrote: >>> Yes. All you have to do after each "git bisect good/bad" is build again, >>> test, and make current build as good or bad. >> >> Will report back if I get any results. When I bisected last time, I >> ended up with a kernel that didn't even boot, but with 5 steps this is >> probably manageable. Will take most of the week though. > > [3/4995]mh@fan:~/linux/git/linux ((6fcf9b1d4d6c...) *%|BISECTING) $ git bislog > git bisect start 'drivers/net/ethernet/realtek/r8169.c' > # good: [4ff36466281428734791d3cc6331b8cca7c76019] r8169: replace get_protocol with vlan_get_protocol > git bisect good 4ff36466281428734791d3cc6331b8cca7c76019 > # bad: [649f0837a8cc2b39329f2de00fa0d04b029291c5] r8169: fix broken Wake-on-LAN from S5 (poweroff) > git bisect bad 649f0837a8cc2b39329f2de00fa0d04b029291c5 > # bad: [098b01ad9837b4d4d0022f407300f069a999e55a] r8169: don't include asm headers directly > git bisect bad 098b01ad9837b4d4d0022f407300f069a999e55a > [4/4996]mh@fan:~/linux/git/linux ((6fcf9b1d4d6c...) *%|BISECTING) $ > > The kernel that I now have is 6fcf9b1d4d6cd38202247de5c0ac7d85c4483abb and > that one throws oopses on booting and won't suspend at all. > > Can I continue from here while still making sense? > Not w/o knowing whether this version is good or bad. Because we're interested in file r8169.c only, you could test r8169.c from the oops-ing kernel on top of a working kernel version. > Greetings > Marc > Heiner