From: Shuah Khan <skhan@linuxfoundation.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>,
Davide Caratti <dcaratti@redhat.com>
Cc: Victor Nogueira <victor@mojatatu.com>,
Baowen Zheng <baowen.zheng@corigine.com>,
Simon Horman <simon.horman@corigine.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Vlad Buslov <vladbu@nvidia.com>, David Ahern <dsahern@gmail.com>,
shuah@kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: tdc errors
Date: Mon, 31 Jan 2022 08:40:23 -0700 [thread overview]
Message-ID: <b1a013a9-0f67-3723-d524-0210ca8cbe9a@linuxfoundation.org> (raw)
In-Reply-To: <53506df1-feed-57e4-48f2-7444922e9bc2@mojatatu.com>
On 1/31/22 5:46 AM, Jamal Hadi Salim wrote:
> On 2022-01-21 11:27, Shuah Khan wrote:
>> On 1/21/22 7:11 AM, Jamal Hadi Salim wrote:
>>> On 2022-01-21 04:36, Davide Caratti wrote:
>>>> On Thu, Jan 20, 2022 at 8:34 PM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>
> [..]
>
>
>>
>> Several tests check for config support for their dependencies in their
>> test code - I don't see any of those in tc-testing. Individual tests
>> are supposed to check for not just the config dependencies, but also
>> any feature dependency e.g syscall/ioctl.
>>
>> Couple of way to fix this problem for tc-testing - enhance the test to
>> check for dependencies and skip with a clear message on why test is
>> skipped.
>>
>> A second option is enhancing the tools/testing/selftests/kselftest_deps.sh
>> script that checks for build depedencies. This tool can be enhanced easily
>> to check for run-time dependencies and use this in your automation.
>>
>> Usage: ./kselftest_deps.sh -[p] <compiler> [test_name]
>>
>> kselftest_deps.sh [-p] gcc
>> kselftest_deps.sh [-p] gcc vm
>> kselftest_deps.sh [-p] aarch64-linux-gnu-gcc
>> kselftest_deps.sh [-p] aarch64-linux-gnu-gcc vm
>>
>> - Should be run in selftests directory in the kernel repo.
>> - Checks if Kselftests can be built/cross-built on a system.
>> - Parses all test/sub-test Makefile to find library dependencies.
>> - Runs compile test on a trivial C file with LDLIBS specified
>> in the test Makefiles to identify missing library dependencies.
>> - Prints suggested target list for a system filtering out tests
>> failed the build dependency check from the TARGETS in Selftests
>> main Makefile when optional -p is specified.
>> - Prints pass/fail dependency check for each tests/sub-test.
>> - Prints pass/fail targets and libraries.
>> - Default: runs dependency checks on all tests.
>> - Optional test name can be specified to check dependencies for it.
>>
>
> Thanks Shuah. We'll look at this approach.
> Question: How do we get reports when the bot finds a regression?
>
>
You might be able to subscribe to test ring notification or subscribe
to Linux stable mailing list.
thanks,
-- Shuah
prev parent reply other threads:[~2022-01-31 15:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 17:22 tdc errors Victor Nogueira
2022-01-20 19:33 ` Jamal Hadi Salim
2022-01-21 7:13 ` Baowen Zheng
2022-01-21 9:36 ` Davide Caratti
2022-01-21 14:11 ` Jamal Hadi Salim
2022-01-21 16:27 ` Shuah Khan
2022-01-31 12:46 ` Jamal Hadi Salim
2022-01-31 15:40 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1a013a9-0f67-3723-d524-0210ca8cbe9a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=baowen.zheng@corigine.com \
--cc=dcaratti@redhat.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=simon.horman@corigine.com \
--cc=victor@mojatatu.com \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).