From: Hari Kalavakunta <kalavakunta.hari.prasad@gmail.com>
To: Sam Mendoza-Jonas <sam@mendozajonas.com>,
fercerpav@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: npeacock@meta.com, akozlov@meta.com
Subject: Re: [PATCH net-next 0/2] GCPS Spec Compliance Patch Set
Date: Tue, 8 Apr 2025 10:01:03 -0700 [thread overview]
Message-ID: <b1abcf84-e187-468f-a05e-e634e825210c@gmail.com> (raw)
In-Reply-To: <ee5feee4-e74a-4dc6-ad8e-42cf9c81cb3c@mendozajonas.com>
On 4/7/2025 2:44 PM, Sam Mendoza-Jonas wrote:
> On 8/04/2025 4:19 am, kalavakunta.hari.prasad@gmail.com wrote:
>
> Looking at e.g. DSP0222 1.2.0a, you're right about the field widths, but
> it's not particularly explicit about whether the full 64 bits is used.
> I'd assume so, but do you see the upper bits of e.g. the packet counters
> return expected data? Otherwise looks good.
>
It is possible that these statistics have not been previously explored
or utilized, which may explain why they went unnoticed. As you pointed
out, the checksum offset within the struct is not currently being
checked, and similarly, the returned packet sizes are also not being
verified.
next prev parent reply other threads:[~2025-04-08 17:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 18:19 [PATCH net-next 0/2] GCPS Spec Compliance Patch Set kalavakunta.hari.prasad
2025-04-07 18:19 ` [PATCH net-next 1/2] net: ncsi: Format structure for longer names kalavakunta.hari.prasad
2025-04-07 18:19 ` [PATCH net-next 2/2] net: ncsi: Fix GCPS 64-bit member variables kalavakunta.hari.prasad
2025-04-07 22:23 ` Paul Fertser
2025-04-07 21:44 ` [PATCH net-next 0/2] GCPS Spec Compliance Patch Set Sam Mendoza-Jonas
2025-04-08 17:01 ` Hari Kalavakunta [this message]
2025-04-08 18:26 ` Paul Fertser
2025-04-08 18:53 ` Hari Kalavakunta
2025-04-08 19:19 ` Paul Fertser
2025-04-08 22:02 ` Hari Kalavakunta
2025-04-08 22:35 ` Paul Fertser
2025-04-08 23:23 ` Hari Kalavakunta
2025-04-09 3:27 ` Hari Kalavakunta
2025-04-09 9:08 ` Paul Fertser
2025-04-09 16:39 ` Hari Kalavakunta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1abcf84-e187-468f-a05e-e634e825210c@gmail.com \
--to=kalavakunta.hari.prasad@gmail.com \
--cc=akozlov@meta.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fercerpav@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=npeacock@meta.com \
--cc=pabeni@redhat.com \
--cc=sam@mendozajonas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).