From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH/RFC net-next 2/5] ravb: correct ptp does failure after suspend and resume Date: Tue, 17 Apr 2018 19:05:56 +0300 Message-ID: References: <20180417085030.32650-1-horms+renesas@verge.net.au> <20180417085030.32650-3-horms+renesas@verge.net.au> <20180417100532.tfjgm4hewmi42al4@ninjato> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Magnus Damm , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Wolfram Sang , Kazuya Mizuguchi To: Wolfram Sang , Simon Horman Return-path: Received: from mail-lf0-f53.google.com ([209.85.215.53]:32810 "EHLO mail-lf0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753415AbeDQQGA (ORCPT ); Tue, 17 Apr 2018 12:06:00 -0400 Received: by mail-lf0-f53.google.com with SMTP id d79-v6so2357148lfd.0 for ; Tue, 17 Apr 2018 09:05:59 -0700 (PDT) In-Reply-To: <20180417100532.tfjgm4hewmi42al4@ninjato> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 04/17/2018 01:05 PM, Wolfram Sang wrote: >> @@ -2302,6 +2305,7 @@ static int __maybe_unused ravb_resume(struct device *dev) >> { >> struct net_device *ndev = dev_get_drvdata(dev); >> struct ravb_private *priv = netdev_priv(ndev); >> + struct platform_device *pdev = priv->pdev; Could infer 'pdev' from 'dev' (avoiding the dereference)... > Minor nit: I'd save this line... > >> + if (priv->chip_id != RCAR_GEN2) >> + ravb_ptp_init(ndev, pdev); > > ... and use ravb_ptp_init(ndev, priv->pdev); here. Agreed, no dire need for the new variable used only once. MBR, Sergei