From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0960EC282CE for ; Fri, 5 Apr 2019 22:14:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC59F21855 for ; Fri, 5 Apr 2019 22:14:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="HRJ6Q4QV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726223AbfDEWON (ORCPT ); Fri, 5 Apr 2019 18:14:13 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:58536 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbfDEWON (ORCPT ); Fri, 5 Apr 2019 18:14:13 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x35M91le130818; Fri, 5 Apr 2019 22:13:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : cc : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=L3+1LocpVKv8DzhKqrezexaCDpFkjP3THYxXIQj6Apc=; b=HRJ6Q4QVqsbraawcpFK+HX5tMT9uTky7pmQlj3uVrrJfdxphebwHuw5lisqxIoE1bAgC 9QvQOcloNME8Uw84QxTr04STh5JIV/5UohNBFG2XoqzP4GAyylCCcUhmF5duQ0U17Qkh d/0QvyfwQpJ0d2lSq7cbrYcVYeY1Axba/NioEdx2KEnvbKo6wLVZVSQJ8DujBDc32THH JUzgnKWpoRSiODNztMtA7OGvvS7SMMWQr6x+fxRtnkZs2aknUzBOtRt2deLidpcxc7w4 7Kw5thhSG+tjZ0Ok5xQ89RmJ6DGhSEQdkpo7jnzIJuPpyvKQMXdZfMUCLgQhucn3hW9X Zw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2130.oracle.com with ESMTP id 2rhwydqbwa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Apr 2019 22:13:58 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x35MDVg9150153; Fri, 5 Apr 2019 22:13:58 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2rp35s3n3m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 05 Apr 2019 22:13:57 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x35MDv9G007697; Fri, 5 Apr 2019 22:13:57 GMT Received: from [10.159.140.147] (/10.159.140.147) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 05 Apr 2019 15:13:57 -0700 Subject: Re: [PATCH net v6] failover: allow name change on IFF_UP slave interfaces To: Stephen Hemminger References: <1554267167-17561-1-git-send-email-si-wei.liu@oracle.com> <20190405144701.25a6b55b@shemminger-XPS-13-9360> Cc: mst@redhat.com, sridhar.samudrala@intel.com, davem@davemloft.net, kubakici@wp.pl, alexander.duyck@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, liran.alon@oracle.com, boris.ostrovsky@oracle.com, vijay.balakrishna@oracle.com From: si-wei liu Organization: Oracle Corporation Message-ID: Date: Fri, 5 Apr 2019 15:13:52 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20190405144701.25a6b55b@shemminger-XPS-13-9360> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9218 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904050146 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9218 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1904050146 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 4/5/2019 2:47 PM, Stephen Hemminger wrote: > On Wed, 3 Apr 2019 00:52:47 -0400 > Si-Wei Liu wrote: > >> >> + if (unlikely(dev->flags & IFF_UP)) { >> + struct netdev_notifier_change_info change_info = { >> + .info.dev = dev, >> + }; >> + >> + call_netdevice_notifiers_info(NETDEV_CHANGE, >> + &change_info.info); >> + } > This notifier is not really necessary, there already is a CHANGENAME > that gets sent. > > NETDEV_CHANGE is used in other cases to mean that the state (flags) > have changed. Honestly I myself did not find NETDEV_CHANGE useful, but it was your call... Anyway, I can remove this notifier and get the patch back to close to v2 except for flag name. https://patchwork.ozlabs.org/patch/1052633/ But what left open is should we really need to notify userspace of link state change around rename, which is what Michael suggested, but turns out too involved. Let me know if you intend to remove it or leave it as-is. -Siwei