From: Paolo Abeni <pabeni@redhat.com>
To: Andrew Lunn <andrew@lunn.ch>, Hariprasad Kelam <hkelam@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kuba@kernel.org, edumazet@google.com, davem@davemloft.net,
sbhatta@marvell.com, gakula@marvell.com, sgoutham@marvell.com
Subject: Re: [net-next PatchV3] octeontx2-pf: Add support to read eeprom information
Date: Thu, 29 Feb 2024 10:14:17 +0100 [thread overview]
Message-ID: <b1d6d86e0d31910abeb4c0d9c43b98947835d316.camel@redhat.com> (raw)
In-Reply-To: <28d5c5b8-bd8f-458a-a62e-bb233add4a2b@lunn.ch>
On Tue, 2024-02-27 at 16:47 +0100, Andrew Lunn wrote:
> On Tue, Feb 27, 2024 at 02:17:22PM +0530, Hariprasad Kelam wrote:
> > Add support to read/decode EEPROM module information using ethtool.
> > Usage: ethtool -m <interface>
> >
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Goutham <sgoutham@marvell.com>
> > ---
> > V3 * remove redundant checks as stack is already doing it.
>
> So still only access to the first 256 bytes, using the old internal
> API.
>
> Disappointing.
>
> And the Signed-of-by: appear to be in the wrong order.
To clarify: If Sunil is the author of this patch, you should put his
SoB first and add a From: tag before the changelog, see:
https://elixir.bootlin.com/linux/v6.8-rc6/source/Documentation/process/6.Followthrough.rst#L199
@Andrew: it looks like the firmware interface is going to be limited
for the time being, are ok with that?
Cheers,
Paolo
next prev parent reply other threads:[~2024-02-29 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 8:47 [net-next PatchV3] octeontx2-pf: Add support to read eeprom information Hariprasad Kelam
2024-02-27 12:42 ` Jiri Pirko
2024-02-27 15:47 ` Andrew Lunn
2024-02-28 10:45 ` [EXT] " Hariprasad Kelam
2024-02-29 9:14 ` Paolo Abeni [this message]
2024-02-29 15:26 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1d6d86e0d31910abeb4c0d9c43b98947835d316.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox