From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta0.migadu.com (out-172.mta0.migadu.com [91.218.175.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61BAB24A05F for ; Thu, 17 Apr 2025 13:38:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744897126; cv=none; b=oaVJ6xFiBXHfeifGigRFNMpO11Yt16VL3km4wPgnP4E69uFgRg1o3+jk7qUo2wfwp3lriooMKNqHMk5gGfovJN4ereXCxIuyR39YXV6cDT0qJNeOpH1azS0rNZzuPJTFGlv9trWuyKm6cAfnfm9xbusELL4JN/wfrhcukD4PwJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744897126; c=relaxed/simple; bh=TuA6iIcB1pBTWGgkSMVSFyR+JdrhY2OU3rmRcvufNOM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=H48eH6ONTWqIL4RrwIUTze/7kcwzPF94z/qH8xZU4H0zVNB2+ZOBl6HFncQ4nTui06VOMv0Au9bdxGRInYNU5Ngc5McxRJ02pvIWOU9KCP+gKcJ3xESFltldh5KfSyadYIGwLLRuwp1zdbjCF2EDmscjLvDLP4gojw8KtqE7HTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=nEiRdiLc; arc=none smtp.client-ip=91.218.175.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="nEiRdiLc" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1744897110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qwWArQ9MRFGh/K/eEnUGpTzjpxS8V4e6gJ+d+OE0Wg4=; b=nEiRdiLcOXl/0JZ4b+MhjzFuKTUxxNRdxzCe3bwodYNkgAoRAzFmzv0T1D76gH31bw08tR 5UchRm/hc0tt2THRDjE6P5O+cHTBxb/L5At8yJCxJEXVlBS4wC4kp6TxL0VeLewIrqf2Rv kaPtM3CIlyDDYAXIvfHE3D5Cn2JsKoM= Date: Thu, 17 Apr 2025 15:38:26 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 1/3] net: mana: Add speed support in mana_get_link_ksettings To: Erni Sri Satya Vennela , kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, longli@microsoft.com, kotaranov@microsoft.com, horms@kernel.org, kent.overstreet@linux.dev, brett.creeley@amd.com, schakrabarti@linux.microsoft.com, shradhagupta@linux.microsoft.com, ssengar@linux.microsoft.com, rosenp@gmail.com, paulros@microsoft.com, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org References: <1744876630-26918-1-git-send-email-ernis@linux.microsoft.com> <1744876630-26918-2-git-send-email-ernis@linux.microsoft.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <1744876630-26918-2-git-send-email-ernis@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 17.04.25 09:57, Erni Sri Satya Vennela wrote: > Add support for speed in mana ethtool get_link_ksettings > operation. This feature is not supported by all hardware. > > Signed-off-by: Erni Sri Satya Vennela > Reviewed-by: Shradha Gupta > Reviewed-by: Haiyang Zhang > --- > drivers/net/ethernet/microsoft/mana/mana_en.c | 42 +++++++++++++++++++ > .../ethernet/microsoft/mana/mana_ethtool.c | 6 +++ > include/net/mana/mana.h | 17 ++++++++ > 3 files changed, 65 insertions(+) > > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c > index 2bac6be8f6a0..ba550fc7ece0 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -1156,6 +1156,48 @@ static int mana_cfg_vport_steering(struct mana_port_context *apc, > return err; > } > > +int mana_query_link_cfg(struct mana_port_context *apc) > +{ > + struct net_device *ndev = apc->ndev; > + struct mana_query_link_config_resp resp = {}; > + struct mana_query_link_config_req req = {}; > + int err; > + > + mana_gd_init_req_hdr(&req.hdr, MANA_QUERY_LINK_CONFIG, > + sizeof(req), sizeof(resp)); > + > + req.vport = apc->port_handle; > + > + err = mana_send_request(apc->ac, &req, sizeof(req), &resp, > + sizeof(resp)); > + > + if (err) { > + netdev_err(ndev, "Failed to query link config: %d\n", err); > + goto out; > + } > + > + err = mana_verify_resp_hdr(&resp.hdr, MANA_QUERY_LINK_CONFIG, > + sizeof(resp)); > + > + if (err || resp.hdr.status) { > + netdev_err(ndev, "Failed to query link config: %d, 0x%x\n", err, > + resp.hdr.status); > + if (!err) > + err = -EPROTO; EPROTO means Protocol error. Thus, ENOTSUPP or EPROTONOSUPPORT is better? Zhu Yanjun > + goto out; > + } > + > + if (resp.qos_unconfigured) { > + err = -EINVAL; > + goto out; > + } > + apc->speed = resp.link_speed_mbps; > + return 0; > + > +out: > + return err; > +} > +