From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D0CC3A5A3 for ; Tue, 27 Aug 2019 19:08:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CFF842070B for ; Tue, 27 Aug 2019 19:08:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730639AbfH0TIA (ORCPT ); Tue, 27 Aug 2019 15:08:00 -0400 Received: from smtprelay0152.hostedemail.com ([216.40.44.152]:36939 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730379AbfH0TIA (ORCPT ); Tue, 27 Aug 2019 15:08:00 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 06D84440B; Tue, 27 Aug 2019 19:07:59 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: knot38_7fb82438d284f X-Filterd-Recvd-Size: 2809 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf20.hostedemail.com (Postfix) with ESMTPA; Tue, 27 Aug 2019 19:07:57 +0000 (UTC) Message-ID: Subject: Re: [PATCH] net: intel: Cleanup e1000 - add space between }} From: Joe Perches To: jeffrey.t.kirsher@intel.com, Forrest Fleming , Andrew Morton Cc: "David S. Miller" , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 27 Aug 2019 12:07:56 -0700 In-Reply-To: References: <20190823191421.3318-1-ffleming@gmail.com> <877726fc009ee5ffde50e589d332db90c9695f06.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.32.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 2019-08-27 at 12:02 -0700, Jeff Kirsher wrote: > On Mon, 2019-08-26 at 20:41 -0700, Joe Perches wrote: > > On Mon, 2019-08-26 at 01:03 -0700, Jeff Kirsher wrote: > > > On Fri, 2019-08-23 at 19:14 +0000, Forrest Fleming wrote: > > > > suggested by checkpatch > > > > > > > > Signed-off-by: Forrest Fleming > > > > --- > > > > .../net/ethernet/intel/e1000/e1000_param.c | 28 +++++++++-- > > > > -------- > > > > 1 file changed, 14 insertions(+), 14 deletions(-) > > > > > > While I do not see an issue with this change, I wonder how > > > important it is > > > to make such a change. Especially since most of the hardware > > > supported by > > > this driver is not available for testing. In addition, this is one > > > suggested change by checkpatch.pl that I personally do not agree > > > with. > > > > I think checkpatch should allow consecutive }}. > > Agreed, have you already submitted a formal patch Joe with the > suggested change below? No. > If so, I will ACK it. Of course you can add an Acked-by: > > Maybe: > > --- > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > > index 287fe73688f0..ac5e0f06e1af 100755 > > --- a/scripts/checkpatch.pl > > +++ b/scripts/checkpatch.pl > > @@ -4687,7 +4687,7 @@ sub process { > > > > # closing brace should have a space following it when it has > > anything > > # on the line > > - if ($line =~ /}(?!(?:,|;|\)))\S/) { > > + if ($line =~ /}(?!(?:,|;|\)|\}))\S/) { > > if (ERROR("SPACING", > > "space required after that close > > brace '}'\n" . $herecurr) && > > $fix) { > > > >