From: Florian Fainelli <f.fainelli@gmail.com>
To: Pawel Dembicki <paweldembicki@gmail.com>, netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/6] net: dsa: vsc73xx: pass value in phy_write operation
Date: Fri, 2 Aug 2024 14:53:44 -0700 [thread overview]
Message-ID: <b20a19cd-8428-4ff2-844c-c214a0099284@gmail.com> (raw)
In-Reply-To: <20240802080403.739509-3-paweldembicki@gmail.com>
On 8/2/24 01:03, Pawel Dembicki wrote:
> In the 'vsc73xx_phy_write' function, the register value is missing,
> and the phy write operation always sends zeros.
>
> This commit passes the value variable into the proper register.
>
> Fixes: 975ae7c69d51 ("net: phy: vitesse: Add support for VSC73xx")
> Signed-off-by: Pawel Dembicki <paweldembicki@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2024-08-02 21:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 8:03 [PATCH net 0/6] net: dsa: vsc73xx: fix MDIO bus access and PHY operations Pawel Dembicki
2024-08-02 8:03 ` [PATCH net 1/6] net: dsa: vsc73xx: fix port MAC configuration in full duplex mode Pawel Dembicki
2024-08-02 20:58 ` Linus Walleij
2024-08-02 21:54 ` Florian Fainelli
2024-08-02 23:12 ` Andrew Lunn
2024-08-02 8:03 ` [PATCH net 2/6] net: dsa: vsc73xx: pass value in phy_write operation Pawel Dembicki
2024-08-02 20:59 ` Linus Walleij
2024-08-02 21:02 ` Linus Walleij
2024-08-02 21:53 ` Florian Fainelli [this message]
2024-08-02 8:04 ` [PATCH net 3/6] net: dsa: vsc73xx: use defined values in phy operations Pawel Dembicki
2024-08-02 21:03 ` Linus Walleij
2024-08-02 21:57 ` Florian Fainelli
2024-08-02 22:15 ` Vladimir Oltean
2024-08-04 23:08 ` Paweł Dembicki
2024-08-02 8:04 ` [PATCH net 4/6] net: dsa: vsc73xx: check busy flag in MDIO operations Pawel Dembicki
2024-08-02 21:04 ` Linus Walleij
2024-08-02 21:54 ` Florian Fainelli
2024-08-02 8:04 ` [PATCH net 5/6] net: dsa: vsc73xx: allow phy resetting Pawel Dembicki
2024-08-02 13:01 ` Russell King (Oracle)
2024-08-02 21:07 ` Linus Walleij
2024-08-02 21:55 ` Florian Fainelli
2024-08-02 8:04 ` [PATCH net 6/6] net: phy: vitesse: repair vsc73xx autonegotiation Pawel Dembicki
2024-08-02 13:03 ` Russell King (Oracle)
2024-08-02 20:40 ` Paweł Dembicki
2024-08-02 21:08 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b20a19cd-8428-4ff2-844c-c214a0099284@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=paweldembicki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).