From: mingming cao <mmc@linux.ibm.com>
To: Dave Marquardt <davemarq@linux.ibm.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
horms@kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, nnac123@linux.ibm.com,
maddy@linux.ibm.com, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org, bjking1@linux.ibm.com,
shaik.abdulla1@ibm.com, stable@vger.kernel.org
Subject: Re: [PATCH net 1/2] ibmveth: h_free logical LAN on open-fail after register
Date: Fri, 25 Sep 2026 12:48:54 -0700 [thread overview]
Message-ID: <b2116532-c9d2-46d9-85e1-28d829e1b1f2@linux.ibm.com> (raw)
In-Reply-To: <87jyo917gv.fsf@linux.ibm.com>
On 9/25/26 12:01 PM, Dave Marquardt wrote:
> This code change is good. But I noticed another thing that's a pretty
> minor bug of useless code just after this:
>
> rc = -ENOMEM;
>
> rc isn't used in that code path after it is set. Is there some reason I
> do not understand to have this here?
Yeah, that |rc = -ENOMEM| at line 728 is dead — set right before |return
0| and never read again. Pre-existing junk. |d43732| set it for the
bounce alloc that used to run next. |d6832| moved the TX LTB earlier and
dropped the bounce, but left the line. After |request_irq| succeeds we
replenish, start TX, and return 0.
It's harmless (not user-visible) — I prefer leaving it out of this Fixes
and letting the MQ series clean it up naturally when it rewrites that
whole open() path. But fine to respin a new version if desired.
Thanks for the review.
Mingming
next prev parent reply other threads:[~2026-09-25 19:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 18:05 [PATCH net 0/2] ibmveth: fix open-fail unwind after LAN registration Mingming Cao
2026-09-25 18:05 ` [PATCH net 1/2] ibmveth: h_free logical LAN on open-fail after register Mingming Cao
2026-09-25 19:01 ` Dave Marquardt
2026-09-25 19:48 ` mingming cao [this message]
2026-09-25 20:36 ` Dave Marquardt
2026-09-25 18:05 ` [PATCH net 2/2] ibmveth: fix TX LTB and filter unwind on open-fail Mingming Cao
2026-09-25 19:08 ` Dave Marquardt
2026-10-01 23:10 ` [PATCH net 0/2] ibmveth: fix open-fail unwind after LAN registration patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2116532-c9d2-46d9-85e1-28d829e1b1f2@linux.ibm.com \
--to=mmc@linux.ibm.com \
--cc=andrew+netdev@lunn.ch \
--cc=bjking1@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=davemarq@linux.ibm.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=nnac123@linux.ibm.com \
--cc=pabeni@redhat.com \
--cc=shaik.abdulla1@ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox