From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tipi-net.de (mail.tipi-net.de [194.13.80.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E09D239BFEB; Mon, 30 Mar 2026 21:03:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.13.80.246 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774904607; cv=none; b=Yi1WtQIVgw8jHshny3YgQjoT0PKRSnGGkdXpmwkhKChMHuAAsTBDqlfR6fQ0tjiVqkVz4v3AkTImSgjOswEkgLpbO6c/KpkUBqzEsT/PB8HrGb3OTjsAMTksg2PJ7EqBExoxkjI/TJUuh5/W6rkE6bpcOnP8ShR8Vo0Q694CsCg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774904607; c=relaxed/simple; bh=w1aLGMLQtidwdL+bfN3B1dZ0hayPSe7uJ0nIHApsbv8=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=NzbPDDtHmtHvwFn8vXx9eqE4/PDhMeplxcNwLSkOhNQux4uudTuxwMi7bKX248CnhGKbuPNNOYl47am+xLJvXXJcoGpCL21e5vs3uDBibXgl6jzLsZvrMPlCMXOaqnBzwmdxipB6Ph6PUrQqZZqj/18qx5lxP/n2hkDoH03q74E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tipi-net.de; spf=pass smtp.mailfrom=tipi-net.de; dkim=pass (2048-bit key) header.d=tipi-net.de header.i=@tipi-net.de header.b=OCXKeTOe; arc=none smtp.client-ip=194.13.80.246 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tipi-net.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tipi-net.de header.i=@tipi-net.de header.b="OCXKeTOe" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 44CA6A56FC; Mon, 30 Mar 2026 23:03:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tipi-net.de; s=dkim; t=1774904595; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=5g17+wuSJArzSX6jeFcyrufBHGNDfuvnCEYVcyEwhVc=; b=OCXKeTOec/NX2wMTgqgkMqTCA6LgqSX9HbMGzFum4qjiwaErWaygC9nhvIoDbeqITeoDcP lTBvTi3LUlq0su43a5qRwNttJ+IjxNhMeDqw3qb9hKYhWl35SPCof194g94ZTC7MOCBE9H /VvfIi4PQS13yNvNrIi10L3yk2JB+BJDb/nLbTh4U+EfCoaXEU7UTSxWbMGIUjnawqvNMx R+2JeCtYlrjwPkg3YWLujUVORx+jSoO7fwjQ2Uw4xWHK8DH9/ToH+mWGgzTsMy83n+OMPw FaDVtnweL6cMsfdkm3Pko2hJwiwagziTL0bdjjiN4yysB2wy3liZmZx/8mK1pQ== Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Mon, 30 Mar 2026 23:03:11 +0200 From: Nicolai Buchwitz To: Mohsin Bashir Cc: netdev@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Doug Berger , Florian Fainelli , Broadcom internal kernel review list , Vikas Gupta , Rajashekar Hudumula , Bhargava Marreddy , Eric Biggers , Arnd Bergmann , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 1/6] net: bcmgenet: convert RX path to page_pool In-Reply-To: References: <20260319115402.353509-1-nb@tipi-net.de> <20260319115402.353509-2-nb@tipi-net.de> Message-ID: X-Sender: nb@tipi-net.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 30.3.2026 20:15, Mohsin Bashir wrote: >> if (priv->crc_fwd_en) { >> - skb_trim(skb, len - ETH_FCS_LEN); >> + skb_trim(skb, skb->len - ETH_FCS_LEN); >> len -= ETH_FCS_LEN; > > Looks like 'len' update here is unnecessary since we are overwriting it > later anyway? Good catch, the len = skb->len assignment added in this patch makes len -= ETH_FCS_LEN dead code since skb_trim already removed the FCS. Will fix in v6. Thanks Nicolai > >> } >> + /* Set up checksum offload */ >> + if (dev->features & NETIF_F_RXCSUM) { >> + rx_csum = (__force __be16)(status->rx_csum & 0xffff); >> + if (rx_csum) { >> + skb->csum = (__force __wsum)ntohs(rx_csum); >> + skb->ip_summed = CHECKSUM_COMPLETE; >> + } >> + } >> + >> + len = skb->len;