From: Alex Elder <elder@linaro.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Leon Romanovsky <leon@kernel.org>,
davem@davemloft.net, kuba@kernel.org, bjorn.andersson@linaro.org,
evgreen@chromium.org, cpratapa@codeaurora.org,
subashab@codeaurora.org, elder@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: ipa: fix IPA validation
Date: Mon, 22 Mar 2021 19:03:43 -0500 [thread overview]
Message-ID: <b24adfcd-1dac-581a-93bb-0ce38133bc0f@linaro.org> (raw)
In-Reply-To: <YFkgsHfldCNkaLSB@lunn.ch>
On 3/22/21 5:56 PM, Andrew Lunn wrote:
>> The solution is to create a user space tool inside the
>> drivers/net/ipa directory that will link with the kernel
>> source files and will perform all the basic one-time checks
>> I want to make.
>
> Hi Alex
>
> Have you found any other driver doing this? Where do they keep there
> code?
>
> Could this be a selftest, put somewhere in tools/testing/selftests.
>
> Or can this be a test kernel module. Eg. we have crypt/testmsg.c which
> runs a number of tests on the crypto subsystem,
> ./kernel/time/test_udelay.c which runs times on udelay.
>
> Rather than inventing something new, please follow other examples
> already in the kernel.
I will. I did see the tools/testing directory and I'll
look at how people have done things there.
I need to try to get it working first, then I'll figure
out where it belongs. I think I'll be able to do a user
space test, but it's a little tricky to be sure it's
actually testing what I want. If that ends up being
too hard, I'll look into kernel test module.
Thanks for the suggestions.
-Alex
> Andrew
>
next prev parent reply other threads:[~2021-03-23 0:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 14:17 [PATCH net-next v2 0/2] net: ipa: fix validation Alex Elder
2021-03-20 14:17 ` [PATCH net-next v2 1/2] net: ipa: fix init header command validation Alex Elder
2021-03-20 14:17 ` [PATCH net-next v2 2/2] net: ipa: fix IPA validation Alex Elder
2021-03-21 8:21 ` Leon Romanovsky
2021-03-21 13:21 ` Alex Elder
2021-03-21 13:49 ` Leon Romanovsky
2021-03-21 17:19 ` Alex Elder
2021-03-22 6:40 ` Leon Romanovsky
2021-03-22 13:17 ` Alex Elder
2021-03-22 14:17 ` Leon Romanovsky
2021-03-22 15:06 ` Alex Elder
2021-03-22 22:56 ` Andrew Lunn
2021-03-23 0:03 ` Alex Elder [this message]
2021-03-22 13:22 ` [PATCH net-next v2 0/2] net: ipa: fix validation Alex Elder
2021-03-22 14:16 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b24adfcd-1dac-581a-93bb-0ce38133bc0f@linaro.org \
--to=elder@linaro.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).