Re: [PATCH net-next v13 5/7] bonding: Update to bond_arp_send_all() to use supplied vlan tags

[Paolo Abeni <pabeni@redhat.com>]

On 10/14/25 1:52 AM, David Wilder wrote:
> @@ -3097,9 +3100,11 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
>  		if (rt->dst.dev == bond->dev)
>  			goto found;
>  
> -		rcu_read_lock();
> -		tags = bond_verify_device_path(bond->dev, rt->dst.dev, 0);
> -		rcu_read_unlock();
> +		if (!tags) {
> +			rcu_read_lock();
> +			tags = bond_verify_device_path(bond->dev, rt->dst.dev, 0);
> +			rcu_read_unlock();
> +		}
>  
>  		if (!IS_ERR_OR_NULL(tags))
>  			goto found;
> @@ -3115,7 +3120,8 @@ static void bond_arp_send_all(struct bonding *bond, struct slave *slave)
>  		addr = bond_confirm_addr(rt->dst.dev, target_ip, 0);
>  		ip_rt_put(rt);
>  		bond_arp_send(slave, ARPOP_REQUEST, target_ip, addr, tags);
> -		kfree(tags);
> +		if  (!(flags & BOND_TARGET_USERTAGS))
> +			kfree(tags);

It's IMHO not obvious from the above code that `tags` is allocated (by
bond_verify_device_path() if and only if !(flags & BOND_TARGET_USERTAGS)

I think it would be more clear if you use the same condition for both
the allocation and the free calls.

/P