From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Joonwoo Park" Subject: Re: [PATCH 2/5] iwlwifi: iwl3945 synchronize interruptand tasklet for down iwlwifi Date: Fri, 11 Jan 2008 10:24:54 +0900 Message-ID: References: <11998765481610-git-send-email-joonwpark81@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, "Zhu, Yi" , linux-wireless@vger.kernel.org, lkml , ipw3945-devel@lists.sourceforge.net To: "Chatre, Reinette" Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ipw3945-devel-bounces@lists.sourceforge.net Errors-To: ipw3945-devel-bounces@lists.sourceforge.net List-Id: netdev.vger.kernel.org Hello Reinette, 2008/1/11, Chatre, Reinette : > > Could synchronize_irq() be moved into iwl_disable_interrupts() ? I am At this time, iwl_disable_interrupts() can be called with irq disabled, so for do that I think additional modification would be needed. > also wondering if we cannot call tasklet_kill() before > iwl_disable_interrupts() ... thus preventing it from being scheduled > when we are going down. Thanks for your catch, it seems tasklet can re-enable interrupts. I'll handle and make an another patch for them at this weekend :) Thanks, Joonwoo ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace