From: Dan Carpenter <error27.lkml@gmail.com>
To: Rakesh Ranjan <rakesh@chelsio.com>
Cc: David Miller <davem@davemloft.net>,
michaelc@cs.wisc.edu, open-iscsi@googlegroups.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
James.Bottomley@suse.de, kxie@chelsio.com
Subject: Re: [RFC-PATCH] libiscsi dhcp handler
Date: Fri, 20 Nov 2009 15:29:24 +0200 [thread overview]
Message-ID: <b263e5900911200529n1c002097q48a625d1bcda4db6@mail.gmail.com> (raw)
In-Reply-To: <4B01577E.2020003@chelsio.com>
On 11/16/09, Rakesh Ranjan <rakesh@chelsio.com> wrote:
> David Miller wrote:
>> From: Rakesh Ranjan <rakesh@chelsio.com>
>> Date: Mon, 16 Nov 2009 18:41:49 +0530
>>
>>> Herein attached patches to support dhcp based provisioning for iSCSI
>>> offload capable cards. I have made dhcp code as generic as possible,
>>> please go through the code. Based on the feedback I will submit final
>>> version of these patches.
>>
>> You can't really add objects to the build before the patch that
>> adds the source for that object.
>>
>
> Hi david,
>
> Fixed patch attached.
>
> Regards
> Rakesh Ranjan
>
The header file changes cause warnings in allmodconfig.
CC [M] drivers/scsi/be2iscsi/be_iscsi.o
+In file included from drivers/scsi/be2iscsi/be_iscsi.c:21:
+include/scsi/libiscsi.h:445: warning: ‘struct net_device’ declared
inside parameter list
+include/scsi/libiscsi.h:445: warning: its scope is only this
definition or declaration, which is probably not what you want
+include/scsi/libiscsi.h:447: warning: ‘struct sk_buff’ declared
inside parameter list
+include/scsi/libiscsi.h:447: warning: ‘struct net_device’ declared
inside parameter list
regards,
dan carpenter
next prev parent reply other threads:[~2009-11-20 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 13:11 [RFC-PATCH] libiscsi dhcp handler Rakesh Ranjan
2009-11-16 13:18 ` David Miller
2009-11-16 13:24 ` Rakesh Ranjan
2009-11-16 13:45 ` Rakesh Ranjan
[not found] ` <4B01577E.2020003-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2009-11-18 3:26 ` Rakesh Ranjan
2009-11-18 7:25 ` David Miller
2009-11-20 13:29 ` Dan Carpenter [this message]
2009-11-21 8:13 ` Dan Carpenter
2010-01-05 6:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b263e5900911200529n1c002097q48a625d1bcda4db6@mail.gmail.com \
--to=error27.lkml@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=davem@davemloft.net \
--cc=kxie@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=rakesh@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).