From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net 1/3] net/ipv6: fix addrconf_sysctl_addr_gen_mode
Date: Fri, 6 Jul 2018 17:28:47 -0600
Message-ID: <b270e9ed-0d97-69cf-a1cb-db36627721da@gmail.com>
References: <cover.1530884498.git.sd@queasysnail.net>
 <f5e0fd3bdfdb6a11e13879c209b0fe5364f136f2.1530884498.git.sd@queasysnail.net>
 <3c53aeaf-912f-8921-c9df-40f2caa1747a@gmail.com>
 <20180706150214.GA25283@bistromath.localdomain>
 <99f4b357-741a-e6e4-1ced-bf70aa9a0262@gmail.com>
 <20180706155857.GA8053@bistromath.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
        Felix Jia <felix.jia@alliedtelesis.co.nz>
To: Sabrina Dubroca <sd@queasysnail.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f193.google.com ([209.85.192.193]:39552 "EHLO
        mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932478AbeGFX2R (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 6 Jul 2018 19:28:17 -0400
Received: by mail-pf0-f193.google.com with SMTP id s21-v6so9553472pfm.6
        for <netdev@vger.kernel.org>; Fri, 06 Jul 2018 16:28:17 -0700 (PDT)
In-Reply-To: <20180706155857.GA8053@bistromath.localdomain>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 7/6/18 9:58 AM, Sabrina Dubroca wrote:
> 
> Right. I'll add that as a separate patch in this series, unless you
> really prefer the change squashed into this patch.

no preference.

> 
> 
>> Looking at other addr_gen_mode sites, addrconf_sysctl_stable_secret is
>> messed up as well. It propagates a change to 'default' to all existing
>> devices.
> 
> I guess it was intentional, given:
> 
>         if (&net->ipv6.devconf_all->stable_secret == ctl->data)
>                 return -EIO;
> 
> It only propagates the mode, and not the secret itself, to all
> devices. After thinking about it for a while, I guess it considers the
> new default not only as default for newly created devices, but also
> for newly added addresses/prefixes.
> Or am I making stuff up?
> 

Maybe Hannes can explain (622c81d57b392). It should have been all
instead of default. As I understand it default is what devices start
with on create and individual devices can be changed. 'All' overrides
device-specific settings. So the above is inconsistent. One of many with
sysctl that makes it frustrating for users.