From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF73ECAAD5 for ; Mon, 29 Aug 2022 16:08:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230216AbiH2QID (ORCPT ); Mon, 29 Aug 2022 12:08:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbiH2QIC (ORCPT ); Mon, 29 Aug 2022 12:08:02 -0400 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5E5C85FD0; Mon, 29 Aug 2022 09:08:01 -0700 (PDT) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 6948518848F2; Mon, 29 Aug 2022 16:08:00 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 5CC5025032B7; Mon, 29 Aug 2022 16:08:00 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 4FD1A9EC0002; Mon, 29 Aug 2022 16:08:00 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Mon, 29 Aug 2022 18:07:59 +0200 From: netdev@kapio-technology.com To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Christian Marangi , Daniel Borkmann , Yuwei Wang , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 net-next 6/6] selftests: forwarding: add test of MAC-Auth Bypass to locked port tests In-Reply-To: References: <20220826114538.705433-1-netdev@kapio-technology.com> <20220826114538.705433-7-netdev@kapio-technology.com> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2022-08-27 20:21, Ido Schimmel wrote: > On Fri, Aug 26, 2022 at 01:45:38PM +0200, Hans Schultz wrote: >> + $MZ $h2 -q -t udp -a $mac -b rand >> + bridge fdb show dev $swp2 | grep -q "$mac vlan 1 master br0" >> + check_err $? "Locked port station move: Entry not found on unlocked >> port" > > Looks like this is going to fail with offloaded data path as according > to fdb_print_flags() in iproute2 both the "extern_learn" and "offload" > flags will be printed before "master". > The output shows like: 74:e1:e1:2c:4f:18 dev eth8 vlan 1 master br0 extern_learn offload sticky locked blackhole "sticky" will of course become "permanent", but I can still make it more resilient by piping grep. I suppose that I will keep the "sticky_no_roaming" test even though it is not really needed here anymore?