From: Florian Fainelli <f.fainelli@gmail.com>
To: Mans Rullgard <mans@mansr.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Juergen Borleis <kernel@pengutronix.de>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: dsa: lan9303: add VLAN IDs to master device
Date: Wed, 16 Feb 2022 13:44:43 -0800 [thread overview]
Message-ID: <b29ad7bc-c454-06c2-7f9e-23007339e4b2@gmail.com> (raw)
In-Reply-To: <20220216204818.28746-1-mans@mansr.com>
On 2/16/22 12:48 PM, Mans Rullgard wrote:
> If the master device does VLAN filtering, the IDs used by the switch
> must be added for any frames to be received. Do this in the
> port_enable() function, and remove them in port_disable().
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Should this have :
Fixes: a1292595e006 ("net: dsa: add new DSA switch driver for the
SMSC-LAN9303")
--
Florian
next prev parent reply other threads:[~2022-02-16 21:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 20:48 [PATCH v2] net: dsa: lan9303: add VLAN IDs to master device Mans Rullgard
2022-02-16 21:44 ` Florian Fainelli [this message]
2022-02-16 23:59 ` Vladimir Oltean
2022-02-20 17:00 ` Vladimir Oltean
2022-02-17 18:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b29ad7bc-c454-06c2-7f9e-23007339e4b2@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox