From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Subject: [PATCH] net/wireless/intersil/hostap: fix defined but not used warnings Date: Sat, 7 Jul 2018 08:35:11 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Jouni Malinen , linux-wireless@vger.kernel.org, Kalle Valo , David Miller , "netdev@vger.kernel.org" Return-path: Received: from bombadil.infradead.org ([198.137.202.133]:49034 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753854AbeGGPfN (ORCPT ); Sat, 7 Jul 2018 11:35:13 -0400 Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: From: Randy Dunlap Fix build warnings in drivers/net/wireless/intersil/hostap/ when CONFIG_PROC_FS is not enabled by marking the unused functions as __maybe_unused. ../drivers/net/wireless/intersil/hostap/hostap_ap.c:70:12: warning: 'ap_debug_proc_show' defined but not used [-Wunused-function] ../drivers/net/wireless/intersil/hostap/hostap_ap.c:994:12: warning: 'prism2_sta_proc_show' defined but not used [-Wunused-function] ../drivers/net/wireless/intersil/hostap/hostap_proc.c:16:12: warning: 'prism2_debug_proc_show' defined but not used [-Wunused-function] ../drivers/net/wireless/intersil/hostap/hostap_proc.c:49:12: warning: 'prism2_stats_proc_show' defined but not used [-Wunused-function] ../drivers/net/wireless/intersil/hostap/hostap_proc.c:177:12: warning: 'prism2_crypt_proc_show' defined but not used [-Wunused-function] ../drivers/net/wireless/intersil/hostap/hostap_hw.c:2901:12: warning: 'prism2_registers_proc_show' defined but not used [-Wunused-function] Signed-off-by: Randy Dunlap Cc: Jouni Malinen Cc: linux-wireless@vger.kernel.org Cc: Kalle Valo Cc: "David S. Miller" Cc: netdev@vger.kernel.org --- drivers/net/wireless/intersil/hostap/hostap_ap.c | 5 +++-- drivers/net/wireless/intersil/hostap/hostap_hw.c | 3 ++- drivers/net/wireless/intersil/hostap/hostap_proc.c | 7 ++++--- 3 files changed, 9 insertions(+), 6 deletions(-) --- linux-next-20180706.orig/drivers/net/wireless/intersil/hostap/hostap_ap.c +++ linux-next-20180706/drivers/net/wireless/intersil/hostap/hostap_ap.c @@ -17,6 +17,7 @@ * (8802.11: 5.5) */ +#include #include #include #include @@ -67,7 +68,7 @@ static void prism2_send_mgmt(struct net_ #ifndef PRISM2_NO_PROCFS_DEBUG -static int ap_debug_proc_show(struct seq_file *m, void *v) +static int __maybe_unused ap_debug_proc_show(struct seq_file *m, void *v) { struct ap_data *ap = PDE_DATA(file_inode(m->file)); @@ -991,7 +992,7 @@ static void prism2_send_mgmt(struct net_ #endif /* PRISM2_NO_KERNEL_IEEE80211_MGMT */ -static int prism2_sta_proc_show(struct seq_file *m, void *v) +static int __maybe_unused prism2_sta_proc_show(struct seq_file *m, void *v) { struct sta_info *sta = m->private; int i; --- linux-next-20180706.orig/drivers/net/wireless/intersil/hostap/hostap_proc.c +++ linux-next-20180706/drivers/net/wireless/intersil/hostap/hostap_proc.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 /* /proc routines for Host AP driver */ +#include #include #include #include @@ -13,7 +14,7 @@ #ifndef PRISM2_NO_PROCFS_DEBUG -static int prism2_debug_proc_show(struct seq_file *m, void *v) +static int __maybe_unused prism2_debug_proc_show(struct seq_file *m, void *v) { local_info_t *local = m->private; int i; @@ -46,7 +47,7 @@ static int prism2_debug_proc_show(struct #endif /* PRISM2_NO_PROCFS_DEBUG */ -static int prism2_stats_proc_show(struct seq_file *m, void *v) +static int __maybe_unused prism2_stats_proc_show(struct seq_file *m, void *v) { local_info_t *local = m->private; struct comm_tallies_sums *sums = &local->comm_tallies; @@ -174,7 +175,7 @@ static const struct seq_operations prism .show = prism2_bss_list_proc_show, }; -static int prism2_crypt_proc_show(struct seq_file *m, void *v) +static int __maybe_unused prism2_crypt_proc_show(struct seq_file *m, void *v) { local_info_t *local = m->private; int i; --- linux-next-20180706.orig/drivers/net/wireless/intersil/hostap/hostap_hw.c +++ linux-next-20180706/drivers/net/wireless/intersil/hostap/hostap_hw.c @@ -32,6 +32,7 @@ #include +#include #include #include @@ -2898,7 +2899,7 @@ static void hostap_tick_timer(struct tim #ifndef PRISM2_NO_PROCFS_DEBUG -static int prism2_registers_proc_show(struct seq_file *m, void *v) +static int __maybe_unused prism2_registers_proc_show(struct seq_file *m, void *v) { local_info_t *local = m->private;