From: Florian Fainelli <f.fainelli@gmail.com>
To: Russell King <rmk+kernel@armlinux.org.uk>, Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: phy: fix marvell phy status reading
Date: Tue, 30 May 2017 09:46:21 -0700 [thread overview]
Message-ID: <b2a497cd-7258-42df-0217-368d87b6ad16@gmail.com> (raw)
In-Reply-To: <E1dFixz-00062r-0n@rmk-PC.armlinux.org.uk>
On 05/30/2017 08:21 AM, Russell King wrote:
> The Marvell driver incorrectly provides phydev->lp_advertising as the
> logical and of the link partner's advert and our advert. This is
> incorrect - this field is supposed to store the link parter's unmodified
> advertisment.
>
> This allows ethtool to report the correct link partner auto-negotiation
> status.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Fixes: be937f1f89ca ("Marvell PHY m88e1111 driver fix")
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-05-30 16:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 15:21 [PATCH] net: phy: fix marvell phy status reading Russell King
2017-05-30 16:06 ` Andrew Lunn
2017-05-30 16:46 ` Florian Fainelli [this message]
2017-05-31 17:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2a497cd-7258-42df-0217-368d87b6ad16@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).