From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3145CC3A59B for ; Sat, 17 Aug 2019 10:28:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E67962086C for ; Sat, 17 Aug 2019 10:28:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DIHlndiE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725966AbfHQK2e (ORCPT ); Sat, 17 Aug 2019 06:28:34 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:37046 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfHQK2e (ORCPT ); Sat, 17 Aug 2019 06:28:34 -0400 Received: by mail-wm1-f65.google.com with SMTP id z23so6021059wmf.2 for ; Sat, 17 Aug 2019 03:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OFTu4dNHPCWGqkF2+IGESK+lqJtRG6YJaLJ0oTLY9QA=; b=DIHlndiECbnYS1YXBGJdCw+NNCyHG/GfozNfa62/WjJACuOX5n/wUpov5XAs2OOLDc +ww+EDbmVTKxOcanzGoAEZ1/KcD7wdR77gAxjZRMRiS6JGtQuMfm8BqfOuXPEYIJ68ts xkjF4FFJYttutHQXWipkktOFaHa0DMKxN4lRlW7qrNO+w7yHHl45D6xBhafp95pyUIS0 MD2DxV57K/Uxp2hAeEM5VqadUW22lR6Nr09xIgM8WzxMvNcrc0DAQet9rZ7SbmbmnotF gJiKW6UkB7GE86I77oHTeuEqnIAwW5jnpCy7cmbQRAUBXGK/ZQRmErMHnYyMcdJfwlWR oaWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OFTu4dNHPCWGqkF2+IGESK+lqJtRG6YJaLJ0oTLY9QA=; b=af0igm0Kvt6FBH9R0mer73oysVXz2yi9AutZDVc9OVlGonBSy5TH0lLl4Xff4+6ikG c53Dhz+eDGns2MLiLVWjShPa8TBMAPR8PFefj0fP8aRYSkDbDz3HtfgHYfCC8vllrGV9 OHQJ68qzwTTFCn9FVtx4uWCscZQo7oHatLQwx43qh2tRy16ff1H1MF9zfBPmVXiesizx Wyz2RhQkZjrlVvRT+sXhgJeCCjpxQpy+95uyxtHJMDA35FTE/9oCKhcjrfmEME4nl67P CvZ7yA0OEmzztNevtB7TMZRj8W0ouPWD8yCr4+5rYeUXhYsGQgKOSBzB+U2IYJ6ywD4N nF0A== X-Gm-Message-State: APjAAAUAUAwofFsd4fRWelHRhbiy22LBd254C5enjgO5ZlP0c1/36okK Tm3dlu2gXrxXTYvcjceKrr4= X-Google-Smtp-Source: APXvYqxK7OuTqcMVaNIFg0Iw6hzxpcWv258PeHroh3x0eLh3tkb7RCFYCr0P5++bsRoGlUdembLrqQ== X-Received: by 2002:a7b:ce1a:: with SMTP id m26mr11392723wmc.60.1566037712315; Sat, 17 Aug 2019 03:28:32 -0700 (PDT) Received: from ?IPv6:2003:ea:8f47:db00:ec01:10b1:c9a3:2488? ([2003:ea:8f47:db00:ec01:10b1:c9a3:2488]) by smtp.googlemail.com with ESMTPSA id f17sm5547279wmf.27.2019.08.17.03.28.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 17 Aug 2019 03:28:31 -0700 (PDT) Subject: Re: [PATCH net-next v2 1/3] net: phy: remove calls to genphy_config_init To: Florian Fainelli , Andrew Lunn , David Miller , Kevin Hilman , Vivien Didelot Cc: "netdev@vger.kernel.org" , "open list:ARM/Amlogic Meson..." References: <62de47ba-0624-28c0-56a1-e2fc39a36061@gmail.com> From: Heiner Kallweit Message-ID: Date: Sat, 17 Aug 2019 12:25:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 16.08.2019 23:58, Florian Fainelli wrote: > On 8/16/19 1:31 PM, Heiner Kallweit wrote: >> Supported PHY features are either auto-detected or explicitly set. >> In both cases calling genphy_config_init isn't needed. All that >> genphy_config_init does is removing features that are set as >> supported but can't be auto-detected. Basically it duplicates the >> code in genphy_read_abilities. Therefore remove such calls from >> all PHY drivers. >> >> v2: >> - remove call also from new adin PHY driver >> >> Signed-off-by: Heiner Kallweit > > Looks good, just one question below: > >> +static int dummy_config_init(struct phy_device *phydev) >> +{ >> + return 0; >> +} >> + >> static struct mdio_device_id __maybe_unused dp83848_tbl[] = { >> { TI_DP83848C_PHY_ID, 0xfffffff0 }, >> { NS_DP83848C_PHY_ID, 0xfffffff0 }, >> @@ -113,13 +113,13 @@ MODULE_DEVICE_TABLE(mdio, dp83848_tbl); >> >> static struct phy_driver dp83848_driver[] = { >> DP83848_PHY_DRIVER(TI_DP83848C_PHY_ID, "TI DP83848C 10/100 Mbps PHY", >> - genphy_config_init), >> + dummy_config_init), >> DP83848_PHY_DRIVER(NS_DP83848C_PHY_ID, "NS DP83848C 10/100 Mbps PHY", >> - genphy_config_init), >> + dummy_config_init), >> DP83848_PHY_DRIVER(TI_DP83620_PHY_ID, "TI DP83620 10/100 Mbps PHY", >> dp83848_config_init), >> DP83848_PHY_DRIVER(TLK10X_PHY_ID, "TI TLK10X 10/100 Mbps PHY", >> - genphy_config_init), >> + dummy_config_init), > > drv->config_init is an optional callback so you could just either pass > NULL as an argument to the macro, or simply remove that parameter? > Yes, this can be simplified. Let's pass NULL. Thanks!