Netdev List
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>,
	David 'equinox' Lamparter <equinox@diac24.net>
Cc: Mat Martineau <martineau@kernel.org>,
	netdev@vger.kernel.org,  mptcp@lists.linux.dev
Subject: Re: [PATCH net-next v2] mptcp: sockopt: implement IPV6_TCLASS
Date: Mon, 27 Jul 2026 19:58:24 +0800	[thread overview]
Message-ID: <b2b89abe26e0c603e929733a32240484b7feaa05.camel@kernel.org> (raw)
In-Reply-To: <f2c103ac-b85e-4c9b-a590-23f63388855f@kernel.org>

Hi David, Matt,

On Tue, 2026-07-14 at 11:53 +0200, Matthieu Baerts wrote:
> Hi David, Geliang,
> 
> On 14/07/2026 11:48, David 'equinox' Lamparter wrote:
> > On Tue, Jul 14, 2026 at 10:22:12AM +0800, Geliang Tang wrote:
> > > Thanks for your patch. However there is already a version under
> > > review
> > > on the MPTCP mailing list that adds IPV6_TCLASS [1] (as well as
> > > IP_TTL
> > > and IPV6_UNICAST_HOPS).
> > > 
> > > https://patchwork.kernel.org/project/mptcp/patch/2617b8684039574734b8622936ef126d6a7cd519.1754986785.git.tanggeliang@kylinos.cn/
> > 
> > Darn, I looked for patches for this & didn't find any, but I've
> > also
> > been carrying this locally for a bit.
> > 
> > Anything I can do to help get your patch moving?
> I was hoping to do some refactoring around Geliang's code, but I
> didn't
> manage to do that so far. I will to see if it is fine to apply
> Geliang's
> patch (after netdevconf) and do the refactoring after.
> 
> @Geliang: do you mind rebasing this series, please? No hurry, I can
> also
> check later on. (And sorry for the delay on that)

I finally had time to do this IPV6_TCLASS refactoring. I merged my
changes into David's patch, keeping David as the patch author and
adding "Co-developed-by" tag for myself.

To verify the correctness of IPV6_TCLASS, I added IPV6_TCLASS support
to "NVMe over MPTCP" feature I'm currently working on, and all the
tests passed.

I will include this IPV6_TCLASS patch in my upcoming v3 of "Fix socket
options used by NVMe over MPTCP" soon.

Thanks,
-Geliang

> 
> Cheers,
> Matt

      reply	other threads:[~2026-07-27 11:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 13:51 [PATCH net-next v2] mptcp: sockopt: implement IPV6_TCLASS David 'equinox' Lamparter
2026-07-14  2:22 ` Geliang Tang
2026-07-14  9:48   ` David 'equinox' Lamparter
2026-07-14  9:53     ` Matthieu Baerts
2026-07-27 11:58       ` Geliang Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2b89abe26e0c603e929733a32240484b7feaa05.camel@kernel.org \
    --to=geliang@kernel.org \
    --cc=equinox@diac24.net \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox