netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hagen Paul Pfeifer <hagen@jauu.net>
To: Changli Gao <xiaosuo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: reduce the lines of code
Date: Fri, 19 Nov 2010 07:35:40 +0100	[thread overview]
Message-ID: <b2c34db84e88366e465af590900ae3db@localhost> (raw)
In-Reply-To: <1290132284-12328-1-git-send-email-xiaosuo@gmail.com>


On Fri, 19 Nov 2010 10:04:44 +0800, Changli Gao <xiaosuo@gmail.com> wrote:

> Use macros to reduce the regularity lines.



This is complete awkward and does not fix anything - on the contrary it

makes it harder to understand the code and no advantage is achieved.



Hagen

  reply	other threads:[~2010-11-19  6:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19  2:04 [PATCH] net: reduce the lines of code Changli Gao
2010-11-19  6:35 ` Hagen Paul Pfeifer [this message]
2010-11-19  7:17   ` Changli Gao
2010-11-19  7:51     ` Eric Dumazet
2010-11-19  7:56       ` [PATCH net-next-2.6] filter: cleanup codes[] init Eric Dumazet
2010-11-19  8:04         ` [PATCH net-next-2.6] filter: use reciprocal divide Eric Dumazet
2010-11-19  8:18           ` Changli Gao
2010-11-19 18:07             ` David Miller
2010-11-19  8:38         ` [PATCH net-next-2.6] filter: cleanup codes[] init Changli Gao
2010-11-19  9:54           ` Eric Dumazet
2010-11-19 11:17             ` [PATCH net-next-2.6] filter: optimize sk_run_filter Eric Dumazet
2010-11-19 12:32               ` Changli Gao
2010-11-19 12:57                 ` Changli Gao
2010-11-19 13:16                   ` [PATCH net-next-2.6 v2] " Eric Dumazet
2010-11-19 14:13                     ` Changli Gao
2010-11-19 17:52                       ` David Miller
2010-11-19 14:17                     ` Tetsuo Handa
2010-11-19 14:35                       ` Eric Dumazet
2010-11-19 16:21               ` [PATCH net-next-2.6] " David Miller
2010-11-19 16:55                 ` Eric Dumazet
2010-11-19 17:05                   ` David Miller
2010-11-19 17:15                     ` Stephen Hemminger
2010-11-19 17:21                       ` David Miller
2010-11-19 17:16                     ` Eric Dumazet
2010-11-19 17:25                       ` David Miller
2010-11-19 12:21             ` [PATCH net-next-2.6] filter: cleanup codes[] init Changli Gao
2010-11-19 18:07               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2c34db84e88366e465af590900ae3db@localhost \
    --to=hagen@jauu.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).