From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hagen Paul Pfeifer Subject: Re: [PATCH] net: reduce the lines of code Date: Fri, 19 Nov 2010 07:35:40 +0100 Message-ID: References: <1290132284-12328-1-git-send-email-xiaosuo@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , To: Changli Gao Return-path: Received: from alternativer.internetendpunkt.de ([88.198.24.89]:47184 "EHLO geheimer.internetendpunkt.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750766Ab0KSGfm (ORCPT ); Fri, 19 Nov 2010 01:35:42 -0500 In-Reply-To: <1290132284-12328-1-git-send-email-xiaosuo@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 19 Nov 2010 10:04:44 +0800, Changli Gao wrote: > Use macros to reduce the regularity lines. This is complete awkward and does not fix anything - on the contrary it makes it harder to understand the code and no advantage is achieved. Hagen