From: Nishit Shah <nsshah.82@gmail.com>
To: netdev@vger.kernel.org
Subject: [PATCH] r8168: r8168 fixes
Date: Wed, 3 Jun 2009 14:14:11 +0530 [thread overview]
Message-ID: <b2d58cb80906030144m6cb7c848se1fe5f471b4688ed@mail.gmail.com> (raw)
Hi,
The following patch fixes three r8168 bugs:
1) vlan tag missing in transmit path. Due to incorrect assignment of
transmit vlan tag option, driver is not able to transmit data on vlan
interface.
2) compilation warning with rtl8168_powerup_pll if CONFIG_PM isn’t defined.
3) compilation warning with unused variable dev in rtl8168_tx_clear.
Signed-off-by: Rajesh Modhwadiya <rajesh.modhwadiya@elitecore.com>
Signed-off-by: Nishit Shah <nishit.shah@elitecore.com>
---
r8168_n.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
--- r8168-8.011.00/src/r8168_n.c 2009-02-18 09:23:21.000000000 +0530
+++ r8168-8.011.00-tmp/src/r8168_n.c 2009-05-15 01:40:57.000000000 +0530
@@ -808,6 +808,8 @@
}
}
+#ifdef CONFIG_PM
+
static void
rtl8168_powerup_pll(struct net_device *dev) { @@ -825,6 +827,8 @@
rtl8168_set_speed(dev, tp->autoneg, tp->speed, tp->duplex); }
+#endif /* CONFIG_PM */
+
static void
rtl8168_get_wol(struct net_device *dev,
struct ethtool_wolinfo *wol) @@ -4151,7 +4155,6 @@
rtl8168_tx_clear(struct rtl8168_private *tp) {
unsigned int i;
- struct net_device *dev = tp->dev;
for (i = tp->dirty_tx; i < tp->dirty_tx + NUM_TX_DESC; i++) {
unsigned int entry = i % NUM_TX_DESC; @@ -4436,7 +4439,7 @@
tp->tx_skb[entry].len = len;
txd->addr = cpu_to_le64(mapping);
- txd->opts2 = cpu_to_le32(rtl8168_tx_vlan_tag(tp, skb));
+ opts2 |= cpu_to_le32(rtl8168_tx_vlan_tag(tp, skb));
wmb();
Rgds,
Nishit Shah.
next reply other threads:[~2009-06-03 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 8:44 Nishit Shah [this message]
2009-06-03 19:49 ` [PATCH] r8168: r8168 fixes Francois Romieu
2009-06-04 4:47 ` David Miller
2009-06-04 6:43 ` nishit.shah
2009-06-04 7:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2d58cb80906030144m6cb7c848se1fe5f471b4688ed@mail.gmail.com \
--to=nsshah.82@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).