Re: [PATCH] net: wwan: t7xx: Add CONFIG_WWAN_ADB_PORT for ADB port control

[Sergey Ryazanov <ryazanov.s.a@gmail.com>]

Hi Wanquan,

On 1/14/26 15:14, wanquan.zhong wrote:
> From: "wanquan.zhong" <wanquan.zhong@fibocom.com>
> 
> Changes from v2:
>    1) Add missing 'net:' subsystem prefix to commit subject for compliance
>    2) Remove redundant "to config" suffix and refine commit wording
>    3) Split overlong Kconfig help text lines to meet 72-char limit
>    4) Align EXPERT dependency desc with WWAN subsystem conventions
> 
> Add a new Kconfig option CONFIG_WWAN_ADB_PORT to control the ADB debug port
> functionality for MediaTek T7xx WWAN modem. This option depends on MTK_T7XX
> and EXPERT, defaults to 'y' to avoid breaking existing debugging workflows
> while mitigating potential security concerns on specific target systems.
> 
> This change addresses security risks on systems such as Google Chrome OS,
> where unauthorized root access could lead to malicious ADB configuration
> of the WWAN device. The ADB port is restricted via this config only; the
> MIPC port remains unrestricted as it is MTK's internal protocol port with
> no associated security risks.

As it was shared before, you cannot stop user having root privileges. He 
can simply unload your 'secured' driver and load another custom build 
module. If the patch is attempt to address a Chrome OS privileges 
separation issue, then, please, fix Chrome OS itself.

For this specific patch:

NACKed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>