netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Samudrala, Sridhar" <sridhar.samudrala@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, Tom Herbert <tom@herbertland.com>
Cc: Alexander Duyck <alexander.h.duyck@intel.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue.
Date: Mon, 11 Sep 2017 23:27:13 -0700	[thread overview]
Message-ID: <b2ea01b3-b984-d59f-cbaf-b2fe6b5d9eea@intel.com> (raw)
In-Reply-To: <1505188437.15310.137.camel@edumazet-glaptop3.roam.corp.google.com>



On 9/11/2017 8:53 PM, Eric Dumazet wrote:
> On Mon, 2017-09-11 at 20:12 -0700, Tom Herbert wrote:
>
>> Two ints in sock_common for this purpose is quite expensive and the
>> use case for this is limited-- even if a RX->TX queue mapping were
>> introduced to eliminate the queue pair assumption this still won't
>> help if the receive and transmit interfaces are different for the
>> connection. I think we really need to see some very compelling results
>> to be able to justify this.
Will try to collect and post some perf data with symmetric queue 
configuration.

> Yes, this is unreasonable cost.
>
> XPS should really cover the case already.
>   
Eric,

Can you clarify how XPS covers the RX-> TX queue mapping case?
Is it possible to configure XPS to select TX queue based on the RX queue 
of a flow?
IIUC, it is based on the CPU of the thread doing the transmit OR based 
on skb->priority to TC mapping?
It may be possible to get this effect if the the threads are pinned to a 
core, but if the app threads are
freely moving, i am not sure how XPS can be configured to select the TX 
queue based on the RX queue of a flow.

Thanks
Sridhar

  reply	other threads:[~2017-09-12  6:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-31 23:27 [RFC PATCH] net: Introduce a socket option to enable picking tx queue based on rx queue Sridhar Samudrala
2017-09-10  1:28 ` Alexander Duyck
2017-09-11 16:48   ` Samudrala, Sridhar
2017-09-11 17:48     ` Alexander Duyck
2017-09-10  5:32 ` Tom Herbert
2017-09-10 15:19 ` Tom Herbert
2017-09-11 16:49   ` Samudrala, Sridhar
2017-09-11 22:07     ` Tom Herbert
2017-09-11 22:50       ` Alexander Duyck
2017-09-12  3:12 ` Tom Herbert
2017-09-12  3:53   ` Eric Dumazet
2017-09-12  6:27     ` Samudrala, Sridhar [this message]
2017-09-12 15:47       ` Eric Dumazet
2017-09-12 22:31         ` Samudrala, Sridhar
2017-09-12 22:53           ` Tom Herbert
2017-09-20  0:34             ` Samudrala, Sridhar
2017-09-20  0:48               ` Tom Herbert
     [not found]                 ` <fe565f14-156e-d703-c91d-d67136a0a0c0@intel.com>
2017-09-20  5:13                   ` Eric Dumazet
2017-09-20 14:18                     ` Tom Herbert
2017-09-20 16:51                       ` Samudrala, Sridhar
2017-09-20 15:30 ` Hannes Frederic Sowa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2ea01b3-b984-d59f-cbaf-b2fe6b5d9eea@intel.com \
    --to=sridhar.samudrala@intel.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).