From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [net-next][PATCH] net/ipv4: fix a net leak Date: Wed, 24 Oct 2018 09:21:01 -0600 Message-ID: References: <1540373788-15078-1-git-send-email-lirongqing@baidu.com> <92af7409-6154-eb85-7d2f-56f5288b8894@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: David Ahern , Li RongQing , netdev@vger.kernel.org, David Miller Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:46443 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726407AbeJXXtf (ORCPT ); Wed, 24 Oct 2018 19:49:35 -0400 Received: by mail-pl1-f193.google.com with SMTP id bb7-v6so2372933plb.13 for ; Wed, 24 Oct 2018 08:21:04 -0700 (PDT) In-Reply-To: <92af7409-6154-eb85-7d2f-56f5288b8894@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/24/18 9:02 AM, David Ahern wrote: > On 10/24/18 3:36 AM, Li RongQing wrote: >> put net when input a invalid ifindex, otherwise it will be leaked >> >> Fixes: 5fcd266a9f64("net/ipv4: Add support for dumping addresses for a specific device") >> Cc: David Ahern >> Signed-off-by: Zhang Yu >> Signed-off-by: Li RongQing >> --- >> net/ipv4/devinet.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c >> index 63d5b58fbfdb..fd0c5a47e742 100644 >> --- a/net/ipv4/devinet.c >> +++ b/net/ipv4/devinet.c >> @@ -1775,8 +1775,10 @@ static int inet_dump_ifaddr(struct sk_buff *skb, struct netlink_callback *cb) >> >> if (fillargs.ifindex) { >> dev = __dev_get_by_index(tgt_net, fillargs.ifindex); >> - if (!dev) >> + if (!dev) { >> + put_net(tgt_net); >> return -ENODEV; >> + } >> >> in_dev = __in_dev_get_rtnl(dev); >> if (in_dev) { >> > > Good catch. IPv6 has the same problem. Will fix that one. > Actually remove that 'Reviewed-by'. You should only call put_net if (fillargs.netnsid >= 0) DaveM: just want to call this out since I mistakenly added the Reviewed-by. This patch should be dropped.