Re: [PATCHv5 net-next 3/3] tools: ynl: add YNL test framework

[Matthieu Baerts <matttbe@kernel.org>]

Hi Hangbin,

On 17/11/2025 03:44, Hangbin Liu wrote:
> Add a test framework for YAML Netlink (YNL) tools, covering both CLI and
> ethtool functionality. The framework includes:
> 
> 1) cli: family listing, netdev, ethtool, rt-* families, and nlctrl
>    operations
> 2) ethtool: device info, statistics, ring/coalesce/pause parameters, and
>    feature gettings
> 
> The current YNL syntax is a bit obscure, and end users may not always know
> how to use it. This test framework provides usage examples and also serves
> as a regression test to catch potential breakages caused by future changes.

Thank you for the v5!

The new version looks good to me:

Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>


I just have one question below, but that's not blocking.

(...)

> diff --git a/tools/net/ynl/tests/test_ynl_cli.sh b/tools/net/ynl/tests/test_ynl_cli.sh
> new file mode 100755
> index 000000000000..cccab336e9a6
> --- /dev/null
> +++ b/tools/net/ynl/tests/test_ynl_cli.sh
> @@ -0,0 +1,327 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Test YNL CLI functionality
> +
> +# Load KTAP test helpers
> +KSELFTEST_KTAP_HELPERS="$(dirname "$(realpath "$0")")/../../../testing/selftests/kselftest/ktap_helpers.sh"
> +# shellcheck source=/dev/null

Out of curiosity, why did you put source=/dev/null? It is equivalent to
"disable=SC1090" and there is no comment explaining why: was it not OK
to use this?

  shellcheck source=../../../testing/selftests/kselftest/ktap_helpers.sh

> +source "$KSELFTEST_KTAP_HELPERS"

(...)

> +cleanup()

Note that with shellcheck 0.11, you will need to disable SC2329 here.
But NIPA is not using this version yet, so no need to change now.

https://www.shellcheck.net/wiki/SC2329

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.