From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.246.84.56 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793171853; b=2DNDmP7gpus9SSedWI6nvugOYHhUqRE3Rafomlya27zQ2suFg/dFXV43+g4spBrvlpCb lrPgEQR66C5KKQTfSUaBNVsDEYzDdwxEQABN85Qh9oqcYef6CHSABpN0DEGCq9AG57ra6 4j0uLJk7EPgoCIa3S//W9tLJ3U9tporPAnuVti2TaUIkCHBTKzdkLma8GDK1M8oiXKlLX 9hjBJVLn0VFt8uSxrhsbETrYk0brutaAwvI+upfXfppe/6MFnZ+JywkbWhY//xpzQyoPl mpwScu/bxm8/C3N2T9I63aMXTzzC/IvOq/oxVvFHG0NuJBXq4a4UfOpT6CL4rZpdabg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793171853; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Last-TLS-Session-Version; bh=nquMCr1WWqc3g25x4aH4wcYWjEl8Qlo/bCJtAzPywf0=; b=Z8gd5WmqHa2lhFcRUagokRIObJW7RBj5tY5ZwMghY6W0zB5Q77gFVSiCPiDE6O174KEC oKQx/h9lgDMezkp/QQuzQx+pd1hbMuuVC6x7HeoXi5IVsgOMrWBWT5FyvoDIfzz2UIfhc rQp0MC4PPrxNj90aU475keJeLbWAdc7lBzcEkF3SDxoNOgw7uVMF6RjTOehIQyoEEygMm 9UJ5SNcqzi3pCvmux5gFR+T6fp+qG/rXKqMcbBBBy8A3RfbvseZ77I0B7gNPLNPydRCoW fSQ/FaNgvRL4RLS0neeRQ/GbFaceP0Qm4GxskqkO0v7E7uShsq4F+0E58XG2QbXXbHw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=Twv5BmZv; arc=none smtp.remote-ip=185.246.84.56 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B530D606A31A; Wed, 28 Oct 2026 07:17:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org B530D606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=Twv5BmZv Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id EE37A1A1372; Wed, 28 Oct 2026 07:17:29 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id C0F1360769; Wed, 28 Oct 2026 07:17:29 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B30F11032906B; Wed, 28 Oct 2026 08:17:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1793171848; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=nquMCr1WWqc3g25x4aH4wcYWjEl8Qlo/bCJtAzPywf0=; b=Twv5BmZvgqoD/QGqoEOSQhAhVHQ3nPsNe4D6eC3nrSg8jO1LgjrhfYxZ5/l9fAGN42EYsz 2T3MlCJy66fl0iP/cX42IOrdHihZFjqJ278/1hQLEYMYZkMABQ7TfVcJD/LsIEBE6+qIC2 tzdPbOQaUKsUrRu/+OI0hE36f2Lrr3AL+XlzUk62oPNJ97HrFHXOV/Q1NrNTWIiUT6GhQ/ I0WkmbxZG46CK0iB1bGfx53h9kVLTEYMLpBDRa90MYcuv1q81btalbtAboOMmWJAcl1WDW 24fCmzrQLrK+lLRzh+ZZHMXELGfIKfkDe8Ne7SzvBOfo066t1s9Ogf3E78CTWg== Message-ID: Date: Wed, 28 Oct 2026 08:17:22 +0100 X-Mailing-List: netdev@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] selftests: drv-net: devmem: Skip when hugetlbfs isn't supported To: Jakub Kicinski Cc: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Paolo Abeni , Simon Horman , Russell King , Shuah Khan , Bobby Eshleman , Stanislav Fomichev , Breno Leitao , thomas.petazzoni@bootlin.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20261021090852.996899-1-maxime.chevallier@bootlin.com> <20261023105258.2a6349f9@kernel.org> <20261027141555.47156425@kernel.org> Content-Language: en-US From: Maxime Chevallier In-Reply-To: <20261027141555.47156425@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 On 10/27/26 22:15, Jakub Kicinski wrote: > On Mon, 26 Oct 2026 10:38:50 +0100 Maxime Chevallier wrote: >> On 10/23/26 19:52, Jakub Kicinski wrote: >>> On Wed, 21 Oct 2026 11:08:51 +0200 Maxime Chevallier wrote: >>>> The devmem selftest requires accessing /proc/sys/vm/nr_hugepages, >>>> which is only available when hugetlbfs is supported. This isn't the >>>> case on all CPU architectures, for example it isn't supported on ARM >>>> 32-bits on cores that don't support LPAE. >>>> >>>> On these devices, the devmem kselftest doesn't skip gracefully >>> >>> We don't require graceful skipping. If anything IMO hiding the stack >>> traces isn't great. >>> >>> If the check is extraneous and makes us fail some tests which don't >>> actually require huge pages please make that clear in the commit >>> message. Otherwise the net benefit of the changes is unclear. >> >> hugetlbfs isn't required for devmem AFAICS, but the blamed commit >> moved the access to nr_hugepages before the actual "is devmem >> actually supported" test. >> >> I don't expect the full test suite to gracefully run/skip for devmem >> on these arm32 platforms TBH, it's likely that devmem is only something >> that's been used on platforms that support hugetlbfs anyways, but >> strictly speaking both features are unrelated. > > For max clarity I should have simply asked - does it make any test which > previously failed pass on any of your platforms? (incl. some WIP > patches that'd add devmem support) That's basically the criteria > I think we should use. I see, then we can drop that patch. It would go from a "file not found" python exception trace to a skip. This is a nice criteria for me to follow, I'll move on to other tests :) Maxime