Netdev List
 help / color / mirror / Atom feed
From: Qingshuang Fu <fuqingshuang@kylinos.cn>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	Willem de Bruijn <willemb@google.com>,
	Anton Danilov <littlesmilingcloud@gmail.com>,
	netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: net: fou_mcast_encap: conditionally load fou module and skip IPv4 case
Date: Fri, 18 Sep 2026 09:52:05 +0800	[thread overview]
Message-ID: <b33bba50-38ce-477a-be0d-ec4eeb0703b1@kylinos.cn> (raw)
In-Reply-To: <20260917152439.64d14833@kernel.org>

在 2026/9/18 06:24, Jakub Kicinski 写道:

> 
> I did not ask about FOU

Apologies, I completely misread the scope.

I've now done a systematic check across tools/testing/selftests/net/.
FOU is the only relevant module lacking any auto-load mechanism
in these tests:

All other tunnel/encap modules (bareudp, vxlan, geneve, gre, ip_gre,
ip6_gre, amt, ifb, xfrm, l2tp) have proper module aliases and can be
auto-loaded via netlink or rtnetlink requests.

In contrast, the fou module has no MODULE_ALIAS_GENL_FAMILY, no
rtnl link alias, and no net-pf-proto alias, so it never auto-loads.

Among the three selftests using FOU, pmtu.sh and rtnetlink.sh already
load the module explicitly, while fou_mcast_encap.sh is the only missing
case.

A naive grep for "encap|tunnel" across the net selftests returns 23
scripts, all of which rely on auto-loading and require no fixes.

> 
> I guess I wasn't clear enough. When I say "before posting v2"
> I was hoping you'd give me a chance to respond too :/
> 
Noted, and sorry for jumping the gun. Won't happen again.


      reply	other threads:[~2026-09-18  1:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 10:01 [PATCH] selftests: net: fou_mcast_encap: conditionally load fou module and skip IPv4 case Qingshuang Fu
2026-09-17  0:40 ` Jakub Kicinski
2026-09-17  3:33   ` Qingshuang Fu
2026-09-17 22:24     ` Jakub Kicinski
2026-09-18  1:52       ` Qingshuang Fu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b33bba50-38ce-477a-be0d-ec4eeb0703b1@kylinos.cn \
    --to=fuqingshuang@kylinos.cn \
    --cc=apw@canonical.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=joe@perches.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=littlesmilingcloud@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox