Re: [PATCH v9 1/5] drm/ras: Introduce the DRM RAS infrastructure over generic netlink

[Riana Tauro <riana.tauro@intel.com>]

On 2/28/2026 9:34 PM, Jakub Kicinski wrote:
> On Sat, 28 Feb 2026 13:38:25 +0530 Riana Tauro wrote:
>>   Documentation/gpu/drm-ras.rst            | 103 +++++++
>>   Documentation/gpu/index.rst              |   1 +
>>   Documentation/netlink/specs/drm_ras.yaml | 115 ++++++++
>>   drivers/gpu/drm/Kconfig                  |  10 +
>>   drivers/gpu/drm/Makefile                 |   1 +
>>   drivers/gpu/drm/drm_drv.c                |   6 +
>>   drivers/gpu/drm/drm_ras.c                | 354 +++++++++++++++++++++++
>>   drivers/gpu/drm/drm_ras_genl_family.c    |  42 +++
>>   drivers/gpu/drm/drm_ras_nl.c             |  56 ++++
>>   drivers/gpu/drm/drm_ras_nl.h             |  24 ++
>>   include/drm/drm_ras.h                    |  75 +++++
>>   include/drm/drm_ras_genl_family.h        |  17 ++
>>   include/uapi/drm/drm_ras.h               |  49 ++++
> 
> Doesn't apply to my local trees any more but _looks_ right :)
> Assuming ./tools/net/ynl/ynl-regen.sh -f doesn't result in a dirty tree:
> > Acked-by: Jakub Kicinski <kuba@kernel.org>

No it does not generate any diff.

Thank you for taking the time to look at this patch and for all the 
helpful suggestions.
Also thanks again for answering all my tool queries.


> 
>> +	if (!info->attrs ||
>> +	    !info->attrs[DRM_RAS_A_ERROR_COUNTER_ATTRS_NODE_ID] ||
>> +	    !info->attrs[DRM_RAS_A_ERROR_COUNTER_ATTRS_ERROR_ID])
>> +		return -EINVAL;
> 
> Sorry for not noticing earlier but you could use GENL_REQ_ATTR_CHECK()
> here. It will give the user a nice error pointing out which attr was
> missing (assuming user space uses a competent ynl-based library).

Tried this. Does print a very user friendly message.
Will send a new rev with these changes

Thank you
Riana