From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Sagi Maimon <maimon.sagi@gmail.com>,
richardcochran@gmail.com, jonathan.lemon@gmail.com,
vadfed@fb.com, jiri@resnulli.us, arkadiusz.kubalewski@intel.com,
davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem
Date: Wed, 20 Dec 2023 10:22:37 +0000 [thread overview]
Message-ID: <b34ebe86-c3bd-48ea-b76b-7b778cc7c086@linux.dev> (raw)
In-Reply-To: <20231220081914.16779-1-maimon.sagi@gmail.com>
On 20/12/2023 08:19, Sagi Maimon wrote:
> When unregistering the DPLL subsystem the priv pointer is different then
> the one used for registration which cause failure in unregistering.
>
> Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
> ---
> drivers/ptp/ptp_ocp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 4021d3d325f9..e7defce8cf48 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -4492,7 +4492,7 @@ ptp_ocp_remove(struct pci_dev *pdev)
> cancel_delayed_work_sync(&bp->sync_work);
> for (i = 0; i < OCP_SMA_NUM; i++) {
> if (bp->sma[i].dpll_pin) {
> - dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, bp);
> + dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, &bp->sma[i]);
> dpll_pin_put(bp->sma[i].dpll_pin);
> }
> }
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2023-12-20 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 8:19 [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem Sagi Maimon
2023-12-20 9:10 ` Jiri Pirko
2023-12-20 10:22 ` Vadim Fedorenko [this message]
2023-12-29 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b34ebe86-c3bd-48ea-b76b-7b778cc7c086@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=jonathan.lemon@gmail.com \
--cc=maimon.sagi@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadfed@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).