* [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem
@ 2023-12-20 8:19 Sagi Maimon
2023-12-20 9:10 ` Jiri Pirko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sagi Maimon @ 2023-12-20 8:19 UTC (permalink / raw)
To: richardcochran, jonathan.lemon, vadfed, jiri,
arkadiusz.kubalewski, davem
Cc: netdev, linux-kernel, maimon.sagi
When unregistering the DPLL subsystem the priv pointer is different then
the one used for registration which cause failure in unregistering.
Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
---
drivers/ptp/ptp_ocp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index 4021d3d325f9..e7defce8cf48 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -4492,7 +4492,7 @@ ptp_ocp_remove(struct pci_dev *pdev)
cancel_delayed_work_sync(&bp->sync_work);
for (i = 0; i < OCP_SMA_NUM; i++) {
if (bp->sma[i].dpll_pin) {
- dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, bp);
+ dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, &bp->sma[i]);
dpll_pin_put(bp->sma[i].dpll_pin);
}
}
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem
2023-12-20 8:19 [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem Sagi Maimon
@ 2023-12-20 9:10 ` Jiri Pirko
2023-12-20 10:22 ` Vadim Fedorenko
2023-12-29 8:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2023-12-20 9:10 UTC (permalink / raw)
To: Sagi Maimon
Cc: richardcochran, jonathan.lemon, vadfed, arkadiusz.kubalewski,
davem, netdev, linux-kernel
Wed, Dec 20, 2023 at 09:19:14AM CET, maimon.sagi@gmail.com wrote:
>When unregistering the DPLL subsystem the priv pointer is different then
>the one used for registration which cause failure in unregistering.
>
>Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem
2023-12-20 8:19 [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem Sagi Maimon
2023-12-20 9:10 ` Jiri Pirko
@ 2023-12-20 10:22 ` Vadim Fedorenko
2023-12-29 8:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Vadim Fedorenko @ 2023-12-20 10:22 UTC (permalink / raw)
To: Sagi Maimon, richardcochran, jonathan.lemon, vadfed, jiri,
arkadiusz.kubalewski, davem
Cc: netdev
On 20/12/2023 08:19, Sagi Maimon wrote:
> When unregistering the DPLL subsystem the priv pointer is different then
> the one used for registration which cause failure in unregistering.
>
> Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
> ---
> drivers/ptp/ptp_ocp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index 4021d3d325f9..e7defce8cf48 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -4492,7 +4492,7 @@ ptp_ocp_remove(struct pci_dev *pdev)
> cancel_delayed_work_sync(&bp->sync_work);
> for (i = 0; i < OCP_SMA_NUM; i++) {
> if (bp->sma[i].dpll_pin) {
> - dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, bp);
> + dpll_pin_unregister(bp->dpll, bp->sma[i].dpll_pin, &dpll_pins_ops, &bp->sma[i]);
> dpll_pin_put(bp->sma[i].dpll_pin);
> }
> }
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem
2023-12-20 8:19 [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem Sagi Maimon
2023-12-20 9:10 ` Jiri Pirko
2023-12-20 10:22 ` Vadim Fedorenko
@ 2023-12-29 8:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-12-29 8:40 UTC (permalink / raw)
To: Sagi Maimon
Cc: richardcochran, jonathan.lemon, vadfed, jiri,
arkadiusz.kubalewski, davem, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Wed, 20 Dec 2023 10:19:14 +0200 you wrote:
> When unregistering the DPLL subsystem the priv pointer is different then
> the one used for registration which cause failure in unregistering.
>
> Fixes: 09eeb3aecc6c ("ptp_ocp: implement DPLL ops")
> ---
> drivers/ptp/ptp_ocp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [v1] ptp: ocp: fix bug in unregistering the DPLL subsystem
https://git.kernel.org/netdev/net/c/97417cd79ce1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-29 8:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-20 8:19 [PATCH v1] ptp: ocp: fix bug in unregistering the DPLL subsystem Sagi Maimon
2023-12-20 9:10 ` Jiri Pirko
2023-12-20 10:22 ` Vadim Fedorenko
2023-12-29 8:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).