From: Paolo Abeni <pabeni@redhat.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>, Eric Dumazet <edumazet@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
Woojung Huh <woojung.huh@microchip.com>,
Arun Ramadoss <arun.ramadoss@microchip.com>
Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next v1 2/3] net: dsa: microchip: Remove redundant optimization in ksz8_w_phy_bmcr
Date: Thu, 23 Nov 2023 11:54:57 +0100 [thread overview]
Message-ID: <b3735179804cb941bbdd17cbdee5efd9a25a72df.camel@redhat.com> (raw)
In-Reply-To: <20231121152426.4188456-2-o.rempel@pengutronix.de>
On Tue, 2023-11-21 at 16:24 +0100, Oleksij Rempel wrote:
> Remove the manual checks for register value changes in the
> ksz8_w_phy_bmcr function. Instead, rely on regmap_update_bits() for
> optimizing register updates.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> drivers/net/dsa/microchip/ksz8795.c | 95 +++++++++--------------------
> 1 file changed, 28 insertions(+), 67 deletions(-)
>
> diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c
> index 835157815937..4c1e21fd87da 100644
> --- a/drivers/net/dsa/microchip/ksz8795.c
> +++ b/drivers/net/dsa/microchip/ksz8795.c
> @@ -951,107 +951,68 @@ static int ksz8_w_phy_ctrl(struct ksz_device *dev, int port, u16 val)
> static int ksz8_w_phy_bmcr(struct ksz_device *dev, int port, u16 val)
> {
> const u16 *regs = dev->info->regs;
> - u8 restart, ctrl, speed, data;
> + u8 restart, speed, ctrl, restart_mask;
Very minor nit and only if you have to repost for some other reason,
please respect the reverse x-mas tree above.
Thanks,
Paolo
next prev parent reply other threads:[~2023-11-23 10:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 15:24 [PATCH net-next v1 1/3] net: dsa: microchip: ksz8: move BMCR specific code to separate function Oleksij Rempel
2023-11-21 15:24 ` [PATCH net-next v1 2/3] net: dsa: microchip: Remove redundant optimization in ksz8_w_phy_bmcr Oleksij Rempel
2023-11-23 10:54 ` Paolo Abeni [this message]
2023-12-06 22:37 ` Vladimir Oltean
2023-11-21 15:24 ` [PATCH net-next v1 3/3] net: dsa: microchip: Fix PHY loopback configuration for KSZ8794 and KSZ8873 Oleksij Rempel
2023-11-23 10:52 ` Paolo Abeni
2023-12-06 8:55 ` Oleksij Rempel
2023-12-06 15:14 ` Vladimir Oltean
2023-12-06 15:54 ` Oleksij Rempel
2023-12-06 16:43 ` Vladimir Oltean
2023-12-07 0:28 ` Vladimir Oltean
2023-12-07 5:15 ` Oleksij Rempel
2023-12-07 14:00 ` Vladimir Oltean
2023-12-20 9:46 ` Oleksij Rempel
2023-12-06 16:46 ` [PATCH net-next v1 1/3] net: dsa: microchip: ksz8: move BMCR specific code to separate function Vladimir Oltean
2023-12-07 4:57 ` Arun.Ramadoss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3735179804cb941bbdd17cbdee5efd9a25a72df.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).