From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C18A343DA27 for ; Tue, 30 Jun 2026 14:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782831265; cv=none; b=ZO/3ZeRV1ddS39+YLBWYgpq31NpEHFi90ooedy+x4kePmE82hXSlWDUu+GswR+ACoa5usm/26+1gyrY4wPia+uDPymHknB5tbAyQsY2PTxARGP0X8Cd6BqrkK/FKQnqNchAp8FawRDQKxtU01N7bTHP4rb5lT6JRgiI7N78k6DY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782831265; c=relaxed/simple; bh=c0UlIyPzVoS38lOqKuNemaPiDL0OuUcyCHqPIE6Dv2g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Ys3rdgkNtUg6Fu3aSSLWfS8+a3RiP2fG/qVHduQRFzmtYMA2fL2WvL/OJwT4me/2JSxjeh89+8jgh0ZHYpQ6A4gp7hD5ZJh/n5KnAhYik2jNxA6XZSJX0R8SxeHuRseVw9rAAFupLg6HGfkKDcseVaRWgWgzeOxM9Hpv+grGb+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=l6Cqv/qG; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="l6Cqv/qG" Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65UEIfOk2171848; Tue, 30 Jun 2026 14:54:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=cQrIpqT0bGUKwqhkD Nycoj7YMDQ9fXIeDCvrzwtwXyI=; b=l6Cqv/qG0lG9gW9JEDdlvcFrWpG3hYXEE xhufDCa+b6fESWgWBPRrGc9QlKAC+x09VVBBWq/RiCTo3P5z5wm7LmOSiqMAF6cW K/98oxoHzLEx7MR/ayQYmxRaOAu9aua7mHSDbuLxu2YKu77rijhl25ANbD3EXhxM BkW3UjWXs5+8XTGLP/QmfBbhHBG05MJLKIcFrwQ8JtpYW3u5rYpOB6nr7AM5E5K5 TYP2wlKPbrVdvwk8AudFdWNxa8STptgxKWHx1bPWolYgMbhBcRcmChjvAqtoqAtg EjRoCb3sQ8DHtVult/OqSIIQ4RIFFMB5f5fbO6nMi+uYsrGmCuJUg== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f26q9y59u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jun 2026 14:54:11 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65UEnflg000654; Tue, 30 Jun 2026 14:54:10 GMT Received: from smtprelay01.wdc07v.mail.ibm.com ([172.16.1.68]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4f2tbhapmu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 30 Jun 2026 14:54:10 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay01.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 65UEs9dg66584862 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 Jun 2026 14:54:09 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5BDBA58054; Tue, 30 Jun 2026 14:54:09 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 096425805F; Tue, 30 Jun 2026 14:54:08 +0000 (GMT) Received: from localhost.localdomain (unknown [9.61.117.151]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 30 Jun 2026 14:54:07 +0000 (GMT) From: Mingming Cao To: netdev@vger.kernel.org Cc: horms@kernel.org, bjking1@linux.ibm.com, haren@linux.ibm.com, ricklind@linux.ibm.com, mmc@linux.ibm.com, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, linuxppc-dev@lists.ozlabs.org, maddy@linux.ibm.com, mpe@ellerman.id.au, Dave Marquardt Subject: [PATCH v1 14/18] ibmveth: Expose per-queue buffer pool details via sysfs Date: Tue, 30 Jun 2026 07:53:21 -0700 Message-Id: X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDEzOSBTYWx0ZWRfX9RmYcCue209R mW1i2BONPAweRXFx0bcxob9HKqpOROAbHQFdhL8ApN4JxhBnJfmmWhtLii1JeDvLqL8gLA/Avby KKyDEZKlL4dKAn8v6jHbQ7NZnoZDf3OCJCyCrOeFF3h5BUjZDKxiE1+SdZ9VKZaJilRuL8V8h7+ O59Bc6jV1zUPw3OdTessRL9kPESyCDXy9xyWbUXkEOU4TYZStQaVITNScKJq7Z0nw0kHuXj1WFz D0puh9nxEqGI6tlrWcjKoGhvmh0WJZeFEEwmCCkpPwdGVNV0r1v0CyxRMueya6b2/YErIGnkOv6 YiVFCo+QFDmgpovvoqgHbnQoSl1bwdv00FPwmHL2Qop/cSys8g7vi4XPemZVII6/SWCguhJaUbt nxS2kbgzmZ41LTbKRFTrj6ls/pGhZ2yYG/16RuMZzE9uw1z7b8lfwOfgR5rKiFYQvK8pkTVcrhi DmVkOFB/2r+B5+/GpEw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDEzOSBTYWx0ZWRfX9rR25HYmADxN CWqy7MmW66XnyXPsfe1gHzDHb4+vwvjnYXepuMuGZNUSdqTMv0aecUfaitq32biCPsr071cb8Jm Vx3LT27QwuLUFhQOV+ZL1Q9UV3tmkgs= X-Proofpoint-GUID: 0SIOoVwqVZdtBMP2YQQpIxFmi3DQL2AO X-Proofpoint-ORIG-GUID: kVLAOIC9FrxUzpURkfNgTt5Dmn0gSRQZ X-Authority-Analysis: v=2.4 cv=WZ88rUhX c=1 sm=1 tr=0 ts=6a43d893 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=Pa5pnD676arj_S7OnbYA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_04,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300139 Add a read-only buffer_pools sysfs attribute under the VIO device that lists size, buff_size, active, and available for every RX queue and pool: runtime per-queue buffer pressure during MQ operation. ethtool -S pool%d_* (previous patch) reports queue-0 static probe geometry only; sysfs is the right place for dynamic per-queue pool state at scale. Signed-off-by: Mingming Cao Reviewed-by: Dave Marquardt --- drivers/net/ethernet/ibm/ibmveth.c | 56 ++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmveth.c b/drivers/net/ethernet/ibm/ibmveth.c index 4e3f49b6346f..ecc472ee8f71 100644 --- a/drivers/net/ethernet/ibm/ibmveth.c +++ b/drivers/net/ethernet/ibm/ibmveth.c @@ -2896,6 +2896,52 @@ static const struct net_device_ops ibmveth_netdev_ops = { #endif }; +static const struct attribute_group ibmveth_attr_group; + +static ssize_t buffer_pools_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct net_device *netdev = dev_get_drvdata(dev); + struct ibmveth_adapter *adapter = netdev_priv(netdev); + int len = 0; + int i, j; + + len += scnprintf(buf + len, PAGE_SIZE - len, + "Queue Pool Size BuffSize Active Available\n"); + len += scnprintf(buf + len, PAGE_SIZE - len, + "----- ---- ---- -------- ------ ---------\n"); + + for (i = 0; i < adapter->num_rx_queues; i++) { + for (j = 0; j < IBMVETH_NUM_BUFF_POOLS; j++) { + struct ibmveth_buff_pool *pool = + &adapter->rx_buff_pool[i][j]; + + len += scnprintf(buf + len, PAGE_SIZE - len, + "%5d %4d %4u %8u %6d %9d\n", + i, j, pool->size, pool->buff_size, + pool->active, + atomic_read(&pool->available)); + + if (len >= PAGE_SIZE - 100) + goto out; + } + } + +out: + return len; +} +static DEVICE_ATTR_RO(buffer_pools); + +static struct attribute *ibmveth_attrs[] = { + &dev_attr_buffer_pools.attr, + NULL, +}; + +static const struct attribute_group ibmveth_attr_group = { + .attrs = ibmveth_attrs, +}; + static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id) { int rc, i, mac_len; @@ -3056,6 +3102,14 @@ static int ibmveth_probe(struct vio_dev *dev, const struct vio_device_id *id) netdev_dbg(netdev, "registered\n"); + rc = sysfs_create_group(&dev->dev.kobj, &ibmveth_attr_group); + if (rc) { + netdev_err(netdev, "failed to create sysfs attributes rc=%d\n", rc); + unregister_netdev(netdev); + free_netdev(netdev); + return rc; + } + return 0; } @@ -3067,6 +3121,8 @@ static void ibmveth_remove(struct vio_dev *dev) cancel_work_sync(&adapter->work); + sysfs_remove_group(&dev->dev.kobj, &ibmveth_attr_group); + for (i = 0; i < IBMVETH_NUM_BUFF_POOLS; i++) kobject_put(&adapter->rx_buff_pool[0][i].kobj); -- 2.39.3 (Apple Git-146)