From: John Fastabend <john.fastabend@gmail.com>
To: Maciej Fijalkowski <maciejromanfijalkowski@gmail.com>,
daniel@iogearbox.net, ast@kernel.org
Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com
Subject: Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples
Date: Mon, 28 Jan 2019 12:57:22 -0800 [thread overview]
Message-ID: <b37c52a3-dd03-745f-793d-1fdbb4e6840f@gmail.com> (raw)
In-Reply-To: <20190128191613.11705-6-maciejromanfijalkowski@gmail.com>
On 1/28/19 11:16 AM, Maciej Fijalkowski wrote:
> From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>
> Make xdp samples consistent with iproute2 behavior and set the
> XDP_FLAGS_UPDATE_IF_NOEXIST by default when setting the xdp program on
> interface. Provide an option for user to force the program loading,
> which as a result will not include the mentioned flag in
> bpf_set_link_xdp_fd call.
>
> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
Patch is fine but I don't really know if being consistent with
iproute2 here gets us much. I guess if users find the "force"
behavior better for a sample that is OK though.
Acked-by: John Fastabend <john.fastabend@gmail.com>
next prev parent reply other threads:[~2019-01-28 20:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 19:16 [PATCH bpf-next v4 0/7] xdp: Avoid unloading xdp prog not attached by sample Maciej Fijalkowski
2019-01-28 19:16 ` [PATCH bpf-next v4 1/7] libbpf: Add a helper for retrieving a map fd for a given name Maciej Fijalkowski
2019-01-28 20:49 ` John Fastabend
2019-01-28 19:16 ` [PATCH bpf-next v4 2/7] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe Maciej Fijalkowski
2019-01-28 20:50 ` John Fastabend
2019-01-28 19:16 ` [PATCH bpf-next v4 3/7] samples/bpf: Convert XDP samples to libbpf usage Maciej Fijalkowski
2019-01-28 19:16 ` [PATCH bpf-next v4 4/7] samples/bpf: Extend RLIMIT_MEMLOCK for xdp_{sample_pkts, router_ipv4} Maciej Fijalkowski
2019-01-28 20:54 ` John Fastabend
2019-01-28 19:16 ` [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples Maciej Fijalkowski
2019-01-28 20:57 ` John Fastabend [this message]
2019-01-29 8:00 ` Jesper Dangaard Brouer
2019-01-29 11:34 ` Jesper Dangaard Brouer
2019-01-30 18:12 ` Maciej Fijalkowski
2019-01-30 19:08 ` Jesper Dangaard Brouer
2019-01-31 2:26 ` Jakub Kicinski
2019-01-31 20:19 ` Jesper Dangaard Brouer
2019-01-28 19:16 ` [PATCH bpf-next v4 6/7] libbpf: Add a support for getting xdp prog id on ifindex Maciej Fijalkowski
2019-01-28 21:07 ` John Fastabend
2019-01-30 17:53 ` Maciej Fijalkowski
2019-01-28 19:16 ` [PATCH bpf-next v4 7/7] samples/bpf: Check the prog id before exiting Maciej Fijalkowski
2019-01-28 21:10 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b37c52a3-dd03-745f-793d-1fdbb4e6840f@gmail.com \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).