From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7C2C282C8 for ; Mon, 28 Jan 2019 20:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58C9B21473 for ; Mon, 28 Jan 2019 20:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iGgHZn2P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727833AbfA1U5g (ORCPT ); Mon, 28 Jan 2019 15:57:36 -0500 Received: from mail-io1-f66.google.com ([209.85.166.66]:36246 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726984AbfA1U5f (ORCPT ); Mon, 28 Jan 2019 15:57:35 -0500 Received: by mail-io1-f66.google.com with SMTP id m19so14718503ioh.3 for ; Mon, 28 Jan 2019 12:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3TbDFo8A9Ih5pnznof20Rhy0CwMXrXhQ/CJTSZa1Nm4=; b=iGgHZn2Pu1y8jZm1BEOECm+eTTde7A/0AQn3f+ZtXtVqz6nXhl41EArBeMAJ+8RxZw f6d/dLd48fd9vmM7nTmoYJy+zqcbm6MEH17lWYzcZZ7cKKvNn9mXm5WRPBlEZ2HlkwC9 b1KGbKegxsYnCWMLqkGtXirBDvEjyZnsaWFqAdR1haIrDaHwwylIRd3XUVuYc6LsbNhj JEVrytetee6I25QwJaaEwMbyzFT/bjfkd00950oVLqENXC7W1xHR0JRRX2o+ywc7P0hd J7fX2HU1F1I3Q8vMQ9y8DJtmwARYaX4dgC2gUmiXgjxu45vA9i+imUyBf6BI1Cby1L4C LBZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3TbDFo8A9Ih5pnznof20Rhy0CwMXrXhQ/CJTSZa1Nm4=; b=J63uMTrG7wh0RXylbzDBD2AixkrLsJphJYrnXVENalB9PIURNN/2f/8QDLkZHnJ+jg 9CuPwn4cEd1Zb82PLed89a0LOR86cOZentF5/drSgjwzCsBj9+tiCIzSON1951aNVer/ vJxv9i+FKkJtxLmQu7tzJWzyI1iTRQdDXlIvOtTtdqsQXSUylOdYeL+DZ4eP8G4HARm3 dJd/Q/rgAGyV8D/tpeOS25+5HxdZ1hHl7yBQc9P/tkd+2jAd0Tnyuf0VTAS+6sB4NY9u JN0bsEu3Qzzh+7fFzZ7Wit0oxExWLrxZSZBDheQW2xIswhQXHvb3Rqad6LbgwE+l1L1T buCA== X-Gm-Message-State: AHQUAuabbpP+s6KqsGf1vZk23k1d7I74+awt7iImwLee4yC7sxx1KI5Z RIBgkSBc+dzV4C74cySLkiXP2Tcw X-Google-Smtp-Source: AHgI3IaAxZkgOLNnZwzWR6WzVzlBUnRbuj6BlxH7ePiwFC7vWIiap0in8P8reCJtLrefefItnFYHDQ== X-Received: by 2002:a5e:9915:: with SMTP id t21mr11959639ioj.4.1548709055102; Mon, 28 Jan 2019 12:57:35 -0800 (PST) Received: from [192.168.86.250] ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id u18sm14326232iom.15.2019.01.28.12.57.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 12:57:34 -0800 (PST) Subject: Re: [PATCH bpf-next v4 5/7] samples/bpf: Add a "force" flag to XDP samples To: Maciej Fijalkowski , daniel@iogearbox.net, ast@kernel.org Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com References: <20190128191613.11705-1-maciejromanfijalkowski@gmail.com> <20190128191613.11705-6-maciejromanfijalkowski@gmail.com> From: John Fastabend Message-ID: Date: Mon, 28 Jan 2019 12:57:22 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190128191613.11705-6-maciejromanfijalkowski@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/28/19 11:16 AM, Maciej Fijalkowski wrote: > From: Maciej Fijalkowski > > Make xdp samples consistent with iproute2 behavior and set the > XDP_FLAGS_UPDATE_IF_NOEXIST by default when setting the xdp program on > interface. Provide an option for user to force the program loading, > which as a result will not include the mentioned flag in > bpf_set_link_xdp_fd call. > > Signed-off-by: Maciej Fijalkowski > Reviewed-by: Jakub Kicinski > --- Patch is fine but I don't really know if being consistent with iproute2 here gets us much. I guess if users find the "force" behavior better for a sample that is OK though. Acked-by: John Fastabend