From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08990A31 for ; Tue, 20 Aug 2024 18:58:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724180307; cv=none; b=aeE4zKVq7bpGg869Qj88+OTlRIm1ahwyLrdWSL6JdbuhpJ/Qo62nLXyGOY4xYB72A5Sr/MpNVzyw17F7A2CTOT5eqzpgwKDdujlcrfGvh2Px70pDRiehpiPsSofo1INsOFSqlQOTgVTBG3CtXZfjEZs1Kqn6uS0h6e7rhaYBXgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724180307; c=relaxed/simple; bh=hyfsZC/q421dcUUkEwtmwVNAJA2F4+p17X/hilcMCyk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EwU0CTD7dfirGs9JbI/6/kv7uj9EBTLpQC3sDVfvqvMOSkuzi5rwuACJ8QjDGSJXKZloUHZs6Evigy61gSn/ud9ZlQhWqxsv5WDllPLNarADbRTMrmWRMLlX0y4AmaFeqzWwaapSxpjKmstodeo7XVUJND21sd5+eRhsBoDBfkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RLzF2My8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RLzF2My8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5EF46C4AF09; Tue, 20 Aug 2024 18:58:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724180305; bh=hyfsZC/q421dcUUkEwtmwVNAJA2F4+p17X/hilcMCyk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RLzF2My8zC+rnx4h2zyQd5nFmEwxNT8oQk/jfxn7WYtavDgAKuQW7ZDV3bAHyhcnJ 6BwPda9XydZ/lGUNgrnv+OQASCAPU7O8fF6iCQDjLFvHr7RTo0EqCD/eZiZd1x7GeW z0BN0XTO2Ii2d1UJJ8OXw+DaLTNTVFeK6pJKUvluOMV8IvXJOBD1Y7rn6xwx7wvuYA 2qLC0pWLsRCWJxCCgYM0v0NajqgQPj/JxBzkIfBYpi135HgfRGHt3LgtNxWmBFziGD SIsr2Iugb7VQos03ajMttF/RFyAkHWeepILAp4ueIR8mtXviBqR/5TQMEQ+qxEPIxv fuHO/RikDPYdg== Message-ID: Date: Tue, 20 Aug 2024 12:58:25 -0600 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 net 2/3] ipv6: fix possible UAF in ip6_finish_output2() Content-Language: en-US To: Eric Dumazet , "David S . Miller" , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, Vasily Averin References: <20240820160859.3786976-1-edumazet@google.com> <20240820160859.3786976-3-edumazet@google.com> From: David Ahern In-Reply-To: <20240820160859.3786976-3-edumazet@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/20/24 10:08 AM, Eric Dumazet wrote: > If skb_expand_head() returns NULL, skb has been freed > and associated dst/idev could also have been freed. > > We need to hold rcu_read_lock() to make sure the dst and > associated idev are alive. > > Fixes: 5796015fa968 ("ipv6: allocate enough headroom in ip6_finish_output2()") > Signed-off-by: Eric Dumazet > Cc: Vasily Averin > --- > net/ipv6/ip6_output.c | 4 ++++ > 1 file changed, 4 insertions(+) > Reviewed-by: David Ahern