From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-pf0-f172.google.com ([209.85.192.172]:43566 "EHLO
        mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750829AbeBTUSW (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 20 Feb 2018 15:18:22 -0500
Received: by mail-pf0-f172.google.com with SMTP id z14so2972653pfe.10
        for <netdev@vger.kernel.org>; Tue, 20 Feb 2018 12:18:22 -0800 (PST)
Subject: Re: [PATCH iproute2-next] ip: don't colorize the master device
To: Stephen Hemminger <stephen@networkplumber.org>,
        netdev@vger.kernel.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>
References: <20180220190846.17356-1-stephen@networkplumber.org>
From: David Ahern <dsahern@gmail.com>
Message-ID: <b39b111c-bbb7-5384-6532-738ee464fd48@gmail.com>
Date: Tue, 20 Feb 2018 13:18:18 -0700
MIME-Version: 1.0
In-Reply-To: <20180220190846.17356-1-stephen@networkplumber.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 2/20/18 12:08 PM, Stephen Hemminger wrote:
> From: Stephen Hemminger <sthemmin@microsoft.com>
> 
> Putting whole string "master eth0" in the interface name color
> is wrong and confusing. Let's just turn color off for all attributes
> of device.
> 
> Fixes: d92cc2d087b0 ("ipaddress: ll_map: Replace ll_idx_n2a() with ll_index_to_name()")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  ip/ipaddress.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 

Change in behavior too. Applied to iproute2-next