From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net] net: diag: Don't double-free TCP_NEW_SYN_RECV sockets
 in tcp_abort
Date: Sat, 7 Jul 2018 06:45:47 -0700
Message-ID: <b3b107e7-3ed9-e0c3-9c11-d91ac6f9f4e5@gmail.com>
References: <20180707073140.202004-1-lorenzo@google.com>
 <20180707.221146.161981342461262899.davem@davemloft.net>
 <248c63e2-6c6c-9c6e-37c2-4c7218f4899b@cumulusnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, astrachan@google.com,
        subashab@codeaurora.org, eric.dumazet@gmail.com
To: David Ahern <dsa@cumulusnetworks.com>,
        David Miller <davem@davemloft.net>, lorenzo@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f67.google.com ([209.85.160.67]:42695 "EHLO
        mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752761AbeGGNpu (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 7 Jul 2018 09:45:50 -0400
Received: by mail-pl0-f67.google.com with SMTP id y8-v6so4087464plr.9
        for <netdev@vger.kernel.org>; Sat, 07 Jul 2018 06:45:50 -0700 (PDT)
In-Reply-To: <248c63e2-6c6c-9c6e-37c2-4c7218f4899b@cumulusnetworks.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 07/07/2018 06:33 AM, David Ahern wrote:
> On 7/7/18 7:11 AM, David Miller wrote:
>> From: Lorenzo Colitti <lorenzo@google.com>
>> Date: Sat,  7 Jul 2018 16:31:40 +0900
>>
>>> Tested: passes Android sock_diag_test.py, which exercises this codepath
>>
>> If this Android test case exercises this path, why didn't it trigger
>> the double free and thus cause this bug to be found much sooner?
>>
> 
> wondering the same. How can I get access to sock_diag_test.py?
> 

I would simply use ss -tKa src :443 command on a live web server ;)

Note to readers : Do not try that unless you want to kill your server.