From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brandon Streiff Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible Date: Tue, 11 Sep 2018 18:52:27 -0500 Message-ID: References: <20180911221536.12993-1-marex@denx.de> <20180911231246.GB11474@lunn.ch> <20180911233251.GE11474@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Andrew Lunn , netdev@vger.kernel.org To: Marek Vasut Return-path: Received: from mx0b-00010702.pphosted.com ([148.163.158.57]:52660 "EHLO mx0b-00010702.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbeILEyW (ORCPT ); Wed, 12 Sep 2018 00:54:22 -0400 In-Reply-To: <20180911233251.GE11474@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/11/2018 6:32 PM, Andrew Lunn wrote: > Please take a look at all the other DT files using the Marvell > chips. You will only ever find "marvell,mv88e6085" or > "marvell,mv88e6190", because everything is compatible to one of these > two. To extend what Andrew stated above, Documentation/devicetree/bindings/net/dsa/marvell.txt (as of 22936c3e6e8c) says which of the two strings you should use for each model. The "marvell,mv88e6085" and "marvell,mv88e6190" compatible strings are best thought of as the "where is the identification register" setting; from that point the driver can figure out everything else. -- brandon