From: Florian Fainelli <f.fainelli@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
Jakub Kicinski <kuba@kernel.org>, Sasha Levin <sashal@kernel.org>,
netdev@vger.kernel.org, olteanv@gmail.com, andrew@lunn.ch
Subject: Re: [PATCH stable 4.14 v3] net: dsa: bcm_sf2: force pause link settings
Date: Tue, 12 Jul 2022 12:30:00 -0700 [thread overview]
Message-ID: <b3c1d411-34c5-197c-5643-6fe4c4ee3723@gmail.com> (raw)
In-Reply-To: <Ys3JIVVpKvEts/Am@kroah.com>
On 7/12/22 12:18, Greg Kroah-Hartman wrote:
> On Thu, Jul 07, 2022 at 05:14:05PM -0700, Florian Fainelli wrote:
>> From: Doug Berger <opendmb@gmail.com>
>>
>> commit 7c97bc0128b2eecc703106112679a69d446d1a12 upstream
>>
>> The pause settings reported by the PHY should also be applied to the
>> GMII port status override otherwise the switch will not generate pause
>> frames towards the link partner despite the advertisement saying
>> otherwise.
>>
>> Fixes: 246d7f773c13 ("net: dsa: add Broadcom SF2 switch driver")
>> Signed-off-by: Doug Berger <opendmb@gmail.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> Link: https://lore.kernel.org/r/20220623030204.1966851-1-f.fainelli@gmail.com
>> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>> ---
>> Changes in v3:
>>
>> - gate the flow control enabling to links that are auto-negotiated and
>> in full duplex
>>
>
> Are these versions better / ok now?
Vladimir "soft" acked it when posting the v3 to v2 incremental diff here:
https://lore.kernel.org/stable/20220707221537.atc4b2k7fifhvaej@skbuf/
so yes, these are good now. Thanks and sorry for the noise.
--
Florian
next prev parent reply other threads:[~2022-07-12 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 0:14 [PATCH stable 4.9 v3] net: dsa: bcm_sf2: force pause link settings Florian Fainelli
2022-07-08 0:14 ` [PATCH stable 4.14 " Florian Fainelli
2022-07-12 19:18 ` Greg Kroah-Hartman
2022-07-12 19:30 ` Florian Fainelli [this message]
2022-07-12 22:07 ` Vladimir Oltean
2022-07-15 14:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3c1d411-34c5-197c-5643-6fe4c4ee3723@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opendmb@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox