From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0002e601.pphosted.com (mx0a-0002e601.pphosted.com [148.163.150.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1D9C44606C; Thu, 3 Sep 2026 12:28:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=148.163.150.75 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788438500; cv=fail; b=q+LwDDIM2mwGXD2+d7kmlrGxOcSnugQREdQw0va1OcRVrmu1Krgl6G2llJjSd5ob/5pRs+Q/raC1xILoqvP6dfmwfCOmLGgWC2A1e3H+TU6NSEr+WHLfIOaZ92YtmzxNaL3SsV5lcmJe6xCMJxnNiwH22P9f0TmqzP9w2X8BBV0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788438500; c=relaxed/simple; bh=Sf1YHHSXXq2yfciXue4oVi3yB185yI1N+L63bH6Xp/0=; h=Message-ID:Date:MIME-Version:CC:Subject:To:References:From: In-Reply-To:Content-Type; b=R27EAP2w3G8Vtr2g/1XxnWUxTomgYnjReK7IvX8cMDDVH316oluB9etaUehsBFh4/6M2flRquPwZMWBR13fzZlzElw1rGZkX6y0mA1c33Fi/jT2MHERMjinm4DCFCgZwEJ56mqHKz/sG+rr13A6uB7Nc7gEqH9q6B/DGkEfJr8Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b=qwePR2hD; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=uJcew870; arc=fail smtp.client-ip=148.163.150.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ti.com header.i=@ti.com header.b="qwePR2hD"; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="uJcew870" Received: from pps.filterd (m0384305.ppops.net [127.0.0.1]) by m0384305.ppops.net (8.18.1.11/8.18.1.11) with ESMTP id 683AHOWr3444687; Thu, 3 Sep 2026 07:28:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint-05-2026; bh=7WSY4Nh5EwoRxZLepcpEIHeql/+4fHiT9bkMAXRbh j0=; b=qwePR2hDbEyl9G0IGE7eTCK1GWePARZRgKRA9u6+/r8X1f8ledrOnIrJt hnD40A947SlRZSZq9kA3bdmXvAmfKNvGtBHhbrJ937jGc2VbjV5byFY0vrJGTclO sQjcUmyP318wn8ol2Yv4Hb+3fRuMC1m35HSUunAPKQUtn8iyN3rGU8WzpNo8g8FK Z3GWJwJEe2WO8PFquhzgDXX0Ys0woPD6oxwUo7xNHNiyRILo5QLc5H6k2S5EXSeF PbKo6LipebOqQpeT2Orav/ZNwLUbBxz5oDITZjFln51+fMqyr0mdOwm4YW5MKQZi N0RooWgWe0fpI29oY4Ve9DZvKkUCw== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012007.outbound.protection.outlook.com [40.107.209.7]) by m0384305.ppops.net (PPS) with ESMTPS id 4gf0jv2psv-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 03 Sep 2026 07:28:04 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XRzf6wV9hdJRPyqxhSllnG0OCF5TaDvnI+uJugC0ti8bJv7vmD45PTmsjPHsq3xQMynfjNxTZtmweInRxRyVGkGPH4oXgfvcPYvTkEQL9Hs5u7pzXQR8AYjqiZtXtfA+gM9dtfa7wTHV7slb9XobN+oaL9IwQxtCpWZFHLac+v0BpITvG0d79NeesjpUsTUuLtkNtrvCgQLQ+PYE5atNbgsM1FJ78srOT8vxwZlpJiE5dm9YyPFNzLWslGPa8inqv7Y7gJTR6xcqxBvTHrH5j8Net1Y08td+wC0BXu2sTZGPZv47TldpZhrKIgO+0afN8XdE16bPEkOo+Kl6CvBbIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7WSY4Nh5EwoRxZLepcpEIHeql/+4fHiT9bkMAXRbhj0=; b=zJEnVs3uLz9RIzsMaHBsaY2C6WDdk0B79/zqtPRkOWNWtip4hED/GHT75aC7pyPhnQz33/t/PQDAz1I4YzK4vTxLfhOWGE+x/DiiM/CDBUJYMpOPdUpZtgOkPpNJPCDvTOQ+Oc9KFdSGpTesal60bY57HEgacfK3VY672CixFc9YhbSl7iPSESK9LMSMF5zKFXJXqImqOoNINWRwi/09QdBozsAvtfizns2MdxnJRqQoNR5CPzAmpqrqfv7SfN/mLJe2/LnUoiDq12GuxjhBbo57Zo4DiytxLtlsQITLFG1d77K+3JIjVQrGPa8OK0ilh5goOuisFetQQyy4bliVyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 198.47.21.194) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=ti.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7WSY4Nh5EwoRxZLepcpEIHeql/+4fHiT9bkMAXRbhj0=; b=uJcew870E6lKSmss+36AcgoAa3awqQR7vO+Y0Vc14IHskcQNeh7YqbnpPLU0Dh2k5bKwBfUqM0jIUnBfc19Z2aTSAUq7PgGG18G6RHA51ANW/UBOo9W4u3q3doGYKCZsNnCjKLxTvCPWu1qFAPp2DdtH/RG+5YYVjdQ664OTsf4= Received: from MW4PR03CA0172.namprd03.prod.outlook.com (2603:10b6:303:8d::27) by IA3PR10MB8187.namprd10.prod.outlook.com (2603:10b6:208:506::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.10; Thu, 3 Sep 2026 12:28:00 +0000 Received: from CO1PEPF000066E8.namprd05.prod.outlook.com (2603:10b6:303:8d:cafe::2b) by MW4PR03CA0172.outlook.office365.com (2603:10b6:303:8d::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.382.12 via Frontend Transport; Thu, 3 Sep 2026 12:27:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 198.47.21.194) smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ti.com; Received-SPF: Pass (protection.outlook.com: domain of ti.com designates 198.47.21.194 as permitted sender) receiver=protection.outlook.com; client-ip=198.47.21.194; helo=flwvzet200.ext.ti.com; pr=C Received: from flwvzet200.ext.ti.com (198.47.21.194) by CO1PEPF000066E8.mail.protection.outlook.com (10.167.249.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.382.8 via Frontend Transport; Thu, 3 Sep 2026 12:27:57 +0000 Received: from DFLE205.ent.ti.com (10.64.6.63) by flwvzet200.ext.ti.com (10.248.192.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 3 Sep 2026 07:27:08 -0500 Received: from DFLE204.ent.ti.com (10.64.6.62) by DFLE205.ent.ti.com (10.64.6.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 3 Sep 2026 07:27:07 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE204.ent.ti.com (10.64.6.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45 via Frontend Transport; Thu, 3 Sep 2026 07:27:08 -0500 Received: from [10.24.68.110] (uda0492258.dhcp.ti.com [10.24.68.110]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 683CR4ui2550502; Thu, 3 Sep 2026 07:27:05 -0500 Message-ID: Date: Thu, 3 Sep 2026 18:00:45 +0530 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird CC: Roger Quadros , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , , , Subject: Re: [PATCH] net: ethernet: ti: davinci_mdio: Drop commas after match table sentinels To: Geert Uytterhoeven References: Content-Language: en-US From: Siddharth Vadapalli In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066E8:EE_|IA3PR10MB8187:EE_ X-MS-Office365-Filtering-Correlation-Id: 360d5145-1c46-4748-6cbe-08df09b6c937 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|82310400026|36860700016|376014|7416014|18002099003|22082099003|10067099003|56012099006; X-Microsoft-Antispam-Message-Info: FcBJ2chVXX4d2CfJS7Ujsa6SU+pHQyMGutXW5FMz/CVBdZpdPtxVtlcD9bOrJI6At0ZMzLNj+MKp2ez1ZM32HOePr2MmlqXHWGebple7W9zRW/duyiJhOc842frYKb9UTb71nsgFHR5YUJabuq4OeZfoZURJs1juaYu4Lhyv8WHSDfd401XLSU86KOU/0aQYhL0K/3AuSntkqZKbFXu3oKcjMz6BTKEeV0j1jQrctByB/Kfx1gnBBOoPnXvhdASNkFuVEK/823B4v8JUnC6vZRz/lWa/JjXHQmFXId7UzIoLRlr+BJgKLKDqKksdbC9btwi9FnqABQICjIKHZcNiMdfk6BqujnNJCdrWbG5HmRuqNingi1LJYRA3fQKVneI1fVHFt6bKnvZLKj02IfFAaQ23gTRoWrGaaC/Wq8yWxjV4pKEt4qbrnE5oaC+xDhqMBNXvHIPtYEkomMgygOMg9VOfm56szAQ8+Y62U5Dtz7oQWIQUbUpvhC1h/8Cze7pcIwgouA+7hSzq4GaTLtNOzjIgdDKLNznui5jHgP+VPpqicNfBFZnaRqa54xLQAOEBMdIeLeCe5uFBF4m9zO6BvWhHO85pxXnvKcHFY0BP8Q4CFf6J4UGqSxl88T5snOQT77G5qbYXHtORPTcvzCqx1hRd8oNDS+ewOs8kRDi63kzOVXtwKHRaYTtzyT6HIP+NyqrSDn51qzoWrw9CEenwsQ== X-Forefront-Antispam-Report: CIP:198.47.21.194;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:flwvzet200.ext.ti.com;PTR:ErrorRetry;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(82310400026)(36860700016)(376014)(7416014)(18002099003)(22082099003)(10067099003)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vyLfrBAj2dxJ3OGB0b98smiA40BBRABWPLyXmlkWus8m9j3uGCrNoTr71fe5d7R44oPO6le1ns4OkhM1GMtkiKjJ1aJ5QuDvxxqfzhYtvVM1z1lojBDgykt1N8kOh51JnmSF7YD3MmrC820P+9NBaLDRihQrdNr0PZsTNmE2XuoGTK3dsg44jgRRepgKUv2KNwdzwkDHD5i9ZZgSgQ2PH1WOjJ5JPQuKZKi+lWYDqSzeOIOaCLb2XIcBkmw+rSuAOxHYlp2HIcP51Nmd11LaNecVNn7Y6pNr2jMCm3rNtWxJnlNjNqVDTS0Kc3MmdFKj8XtneJmf4HIFuWT0SIFZCbf9pclbrhs0QTiF3sbtTM2ghtZCqPYdue9dDVX/wBSAVB0ke+Uyc7ZPEeWjfllrgVrIv6a5eMqwGZksbtUpoXo2lPLcrW50QK5xprz2QTAY X-Exchange-RoutingPolicyChecked: MGkmiX3R35IozZ8+aqQ2kNu1vCzqjTh4yHNsRxT++vFYJmnTo/nj15liGEljRn2Ga7DVNUkYTvqiKruEl/1W1Lmb3bEwYCj2XQS+sXuywapxo89o2nxUOaudNbA/3EaMtunr3ut2EUoJ/FOHc6aZkAe9/hTfmu1QBu/g4sqH0dW63QyITOlY4MgNtHpC+WbzkDogblVzJnwzyPLD43SYH9nIWwiSXF249Cmuc7ZwNiZ4qTq/JRcDDJxK/ftbqO/4fr393s4T+L+6BoSjawjXMh7BuE5p6Jk7jRKmOGiF28airkUdBFZkWWIWNoruzEJ0R/MqCWvOSeyD0ZO6R/TFKQ== X-OriginatorOrg: ti.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2026 12:27:57.3134 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 360d5145-1c46-4748-6cbe-08df09b6c937 X-MS-Exchange-CrossTenant-Id: e5b49634-450b-4709-8abb-1e2b19b982b7 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7;Ip=[198.47.21.194];Helo=[flwvzet200.ext.ti.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066E8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR10MB8187 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDEwOCBTYWx0ZWRfX/QiGkR916tSp E968Q3Zi+CLyRLPh54HwiMtF+i9ai6dkiHn4YWkjA+1IjIDlLqwGlkYfvJwdN2g6JmpvSXllk23 1dRzh2pyN237ey7SEFoY3AdP3L5Su9s= X-Authority-Analysis: v=2.4 cv=J6eaKgnS c=1 sm=1 tr=0 ts=6a9967d4 cx=c_pps a=OJmONvCW+i+0F2OUQkAdQg==:117 a=iwqwCZQqcuTv3JOpYdM7/Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=V5UXEbMT0ywA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Z8NIEmU8O1QQgoT56wFK:22 a=taLDd7a_hP9WKsMzeGRc:22 a=VwQbUJbxAAAA:8 a=-QZzckPosbSnFBlnYnAA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: 3fr1HGo7QJV8Opu-SpaV_Ab3IJXXp_z6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDEwOCBTYWx0ZWRfX8aN8Y/5g1vmZ +2zq7yGWOJQ3UE8oUxneEbI3Xay4eUpy33awOYhvayTa3EwuImIy7/SOfR4pEHwnneJiU2W0HGo ku7DCvKgC4+gZnFCpP+i72f4SiyhEa/1TnaDwNmcRRg29l7FcNDN6g9/zPk1ZmJKtV9BakXO0dz uLfr2yWDRdLXd5sbNnr7GV4z/CZkDqoSleEI1sR8Ktkh0+XiM3nQXJ3U/EBFLnFLWNgeNhbMnx/ VT80dnbME5bNuTA4tmyk1yCHcRERvy7u0pf0XeKHYCyCR4SPZGjxrPLf5zNx9KsS8trbSMfZ/lZ A97K39tk5WOIzuJ9ZLw2S8X99w4IXFaoher/2XzgPhvpxpkVtuXsI/5zLiIjWbO6zjI1V+iBxJW PWqHAbfzo0rDmoeEjBYPh9SejBgUCUsLvHQnNCW9Rr2GFD0OEnPbp2PvvxG/Da4dF6ghvnTPCOZ koHDs3n2BZEq+jJaPcw== X-Proofpoint-ORIG-GUID: 3fr1HGo7QJV8Opu-SpaV_Ab3IJXXp_z6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_03,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 clxscore=1011 adultscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030108 On 03/09/26 17:36, Geert Uytterhoeven wrote: > It does not make sense to have a comma after a sentinel, as any new > elements must be added before the sentinel. While I agree with it, this seems to require a 'cleanup-series' rather than an individual patch, given the following statistics: As of [0], running git grep "sentinel.*}" drivers/net/ | wc -l gives 84 and looking for the ones that terminate in a comma by running git grep "sentinel.*}," drivers/net/ | wc -l gives 38 So there are '37' other instances (apart from davinci_mdio.c) in drivers/net alone that require a cleanup. Looking at Linux overall by running git grep "sentinel.*}," | wc -l gives 396 Since this isn't a functional change, I am not sure why a specific change is required in davinci_mdio.c, unless you plan to cleanup the remaining '395' occurrences in the remaining code as well. I am not against the patch, but the reason for picking just davinci_mdio.c for cleanup isn't clear to me based on the commit message. [0]: commit 940de590b839 Merge tag 'hardening-v7.3-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux > > Signed-off-by: Geert Uytterhoeven > --- > drivers/net/ethernet/ti/davinci_mdio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c > index 48f85a3649b26548..5bec72f2f51dc548 100644 > --- a/drivers/net/ethernet/ti/davinci_mdio.c > +++ b/drivers/net/ethernet/ti/davinci_mdio.c > @@ -510,7 +510,7 @@ static const struct soc_device_attribute k3_mdio_socinfo[] = { > { .family = "J7200", .data = &am65_mdio_soc_data }, > { .family = "J721E", .data = &am65_mdio_soc_data }, > { .family = "J721S2", .data = &am65_mdio_soc_data }, > - { /* sentinel */ }, > + { /* sentinel */ } > }; > > #if IS_ENABLED(CONFIG_OF) > @@ -521,7 +521,7 @@ static const struct davinci_mdio_of_param of_cpsw_mdio_data = { > static const struct of_device_id davinci_mdio_of_mtable[] = { > { .compatible = "ti,davinci_mdio", }, > { .compatible = "ti,cpsw-mdio", .data = &of_cpsw_mdio_data}, > - { /* sentinel */ }, > + { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, davinci_mdio_of_mtable); > #endif Regards, Siddharth.