From: "Arinzon, David" <darinzon@amazon.com>
To: "Dr. David Alan Gilbert" <linux@treblig.org>,
"Agroskin, Shay" <shayagr@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>
Cc: "Dagan, Noam" <ndagan@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: Of ena auto_polling
Date: Sun, 3 Nov 2024 19:02:59 +0000 [thread overview]
Message-ID: <b3df5db4bea6401095b908b3632bb09e@amazon.com> (raw)
In-Reply-To: <ZyZ3AWoocmXY6esd@gallifrey>
> Hi,
> I noticed that commit:
> commit a4e262cde3cda4491ce666e7c5270954c4d926b9
> Author: Sameeh Jubran <sameehj@amazon.com>
> Date: Mon Jun 3 17:43:25 2019 +0300
>
> net: ena: allow automatic fallback to polling mode
>
> added a 'ena_com_set_admin_auto_polling_mode()' that's unused.
> Is that the intention?
> Because that then makes me wonder how
> admin_queue->auto_polling
> gets set, and then if the whole chunk is unused?
>
> Thanks,
>
> Dave
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org
> |_______/
Hi Dave,
The auto polling mode was written as a fallback in case there are issues with interrupts,
it is currently not used by the ENA Linux driver, from Linux's perspective, it can be removed.
next prev parent reply other threads:[~2024-11-03 19:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-02 19:01 Of ena auto_polling Dr. David Alan Gilbert
2024-11-03 19:02 ` Arinzon, David [this message]
2024-11-03 19:43 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3df5db4bea6401095b908b3632bb09e@amazon.com \
--to=darinzon@amazon.com \
--cc=akiyano@amazon.com \
--cc=linux@treblig.org \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).